Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds bus stop map. #32

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Adds bus stop map. #32

wants to merge 5 commits into from

Conversation

francocipollone
Copy link
Contributor

@francocipollone francocipollone commented Aug 24, 2023

🎉 New feature

Closes #28

Summary

  • Bus stop map is added

XODR

It is a single road (two-way) devided in three lane sections(LS):

  • LS0: 2 lanes ( 1, -1)
  • LS1: 3 lanes (2, 1, -1) -> Lane 2 is of type: special1 (bus stop for our case)
  • LS2: 2 lanes ( 1, -1)

It is oriented South->North

geoJSON

  • Only provides information about the lane(bus stop lane) that is of type Special 1 and its boundaries.

Test it

WIDTH=4 EXTENSIONS_LENGTH=30 BUS_STOP_LENGTH=15 empy3 templates/bus_stop.xml.em > generated_file.xodr

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone
Copy link
Contributor Author

CC: @liangfok
Here there are the generated xodr and geojson files.
https://github.com/maliput/maliput_xodr/tree/francocipollone/bus_stop/resources/bus_stop

@liangfok
Copy link
Contributor

Thanks. I'll test this ASAP.

@francocipollone
Copy link
Contributor Author

From internal chat this map has to change to:
image

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone
Copy link
Contributor Author

image

And geojson information provides info ONLY about the bus stop lane.
(Left boundary, center linestring(Lane of type: Special 1") and right boundary )
image

@francocipollone
Copy link
Contributor Author

Ready for another pass @liangfok

@liangfok
Copy link
Contributor

Thanks, I'll test this ASAP.

@francocipollone
Copy link
Contributor Author

Gently ping to check if this PR is mergeable as it is. @liangfok

@francocipollone
Copy link
Contributor Author

I need to fix minor conflicts due to the last PRs that got merged. However, let me know if this PR is mergeable @liangfok

@liangfok
Copy link
Contributor

liangfok commented Dec 6, 2023

Sorry, not yet. The bus stop map continues to be relatively low priority as of now. We're focused on getting some of the other maps to work in our downstream project before returning to this map. It'll probably be another month or so before we need this map, but I'd appreciate if you could resolve the conflicts in the meantime.

Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
@francocipollone
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map request: Bus stop lane
2 participants