Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move our packages to use "@malloy-lang" scope (which we own on npm) #87

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

bporterfield
Copy link
Collaborator

There is a concern that perhaps someone would think we have published npm packages (we have not) and if some nefarious actor grabs a package on npm with a name we're using, some other developer might intend to install a malloy package and accidentally install the bad package.

This change resolves that concern by scoping the packages to @malloy-lang/{package-name} - an organization name in npm that we own - with the exception of the VScode extension. VSCode extensions have chosen (possibly poorly?) to utilize package.json as the manifest file for an extension - but they do not support all possible values for the name property and as such do not support scoped names.

While it is not intended to be installed via npm, we have reserved the malloy-vscode name on npm by publishing the vs-code package to it.

@christopherswenson
Copy link
Contributor

Looks great 👍

@christopherswenson christopherswenson self-requested a review November 1, 2021 22:42
@bporterfield bporterfield merged commit aeeb23e into main Nov 1, 2021
@bporterfield bporterfield deleted the scopedPackaged branch November 1, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants