Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change #419 breaks slideshows using recommended FOUC CSS #423

Closed
andymb opened this issue Jan 28, 2014 · 2 comments
Closed

Change #419 breaks slideshows using recommended FOUC CSS #423

andymb opened this issue Jan 28, 2014 · 2 comments

Comments

@andymb
Copy link

andymb commented Jan 28, 2014

http://jquery.malsup.com/cycle2/faq/ suggests using CSS to prevent FOUC on slides by setting them to 'display: none;' before Cycle2 fires.

Change #419 changes the slide hide/show mechanism to use 'visibility' instead and so slides hidden to prevent FOUC are never displayed.

@andymb
Copy link
Author

andymb commented Jan 28, 2014

I should add that the right fix for anyone preventing FOUC in this way is to change their CSS, either to

1 - put 'display: block' on the current slide,

or, better as it goes with the rationale for Malsup's code change #419,

2 - change your FOUC code to use visibility instead.

Hope this helps anyone waking up to 'broken' slideshows.

@malsup
Copy link
Owner

malsup commented Jan 28, 2014

Thanks for catching and reporting this.

@malsup malsup closed this as completed Jan 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants