Updated version to allow for them to work in table cells #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…its original size and maintaining aspect ratio. This will allow for initializing with many images with different sizes. Original size and size_y options should be backward compatible.
|
I added a new revision, this one more major than the previous. In my use case, my images are all different aspect ratios and slightly different sizes. I didn't want to initialize hoverpulse individually for each image, so I added a new option Magnify that can be used in place of the size and size_y options. See commit note for more detail. Let me know if you have any feedback. |
|
Nostalgic PR for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use this plugin with the images being individually placed in the a left most table cell for multiple rows, but ran into some issues because of the fact that they were no longer contained in a block style element. At first, I made an update the changed the table cell to a block, but throws off all the original styling of the table and how the cell aligns with the rest of the cells. Then I decided to just wrap the img in a div in the case that the parent container is a table cell and it seems to work like a charm.