-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically configure boolean attributes for non-XML documents #386
Conversation
f4eb69f
to
f07b533
Compare
Pull Request Test Coverage Report for Build 6195719017
💛 - Coveralls |
I'm going to try to take the tests I wrote to demonstrate the bools-plus-XML issue in #385 and maybe get us a little more coverage on this branch, if it's ok with you. |
@mcdonc I took upon me to do this work now, cherry-picking your test cases and fixing some minor expectation issues. I fixed a minor issue as a result, namely that an XML template (i.e. starting with "<?xml") provided as |
Thanks Malthe! nice work |
This is now released as 4.2.0. |
Boolean attributes are now automatically configured for templates in non-XML mode, presuming that we're being used to generate HTML.
This means that the same loading mechanism can be used for both XML and HTML-based templates.
The list of attributes is defined in
chameleon.zpt.template
:See #385 for more context.