Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique ID to divs to support multiple Ploltly graphs per notebook #1

Merged
merged 1 commit into from
Feb 9, 2018
Merged

Add unique ID to divs to support multiple Ploltly graphs per notebook #1

merged 1 commit into from
Feb 9, 2018

Conversation

hayleigh-dot-dev
Copy link
Contributor

Currently, attempting to create more than one Plotly graph in a notebook causes the following error:

WARN: Calling Plotly.plot as if redrawing but this container doesn't yet have a plot. 
<div id=​"plotly" width=​"550" height=​"450" class=​"js-plotly-plot">​…​</div>​

I suspect this is due to the static plotly ID being assigned to the divs. Instead, this will generate a random id for each plot.

@mamatsunami mamatsunami merged commit 3590532 into mamatsunami:master Feb 9, 2018
@mamatsunami
Copy link
Owner

hi @pd-andy !
thanks for your fix ;)

@hayleigh-dot-dev
Copy link
Contributor Author

hayleigh-dot-dev commented Feb 9, 2018

No problem! I forgot to do it, but it might be a good idea to update package.json version to 1.1.0 to reflect the change.

Edit: and publish the new version to npm!

@mamatsunami
Copy link
Owner

Oops, you're right !

It's done and publish to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants