Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read custom_multichannels from .condarc #1240

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

jonashaag
Copy link
Contributor

@jonashaag jonashaag commented Oct 25, 2021

Is this all that it takes to fix #1236?! Seems to work in my limited manual tests so far.

Where should I put tests for this change?

@wolfv
Copy link
Member

wolfv commented Oct 26, 2021

yep, that should be it!

I've already added some tests in

TEST(ChannelContext, custom_multichannels)

@jonashaag
Copy link
Contributor Author

Yes I saw those but they don't test the .condarc reading, otherwise we would have realised the missing option already.

@wolfv
Copy link
Member

wolfv commented Oct 26, 2021

I wonder if we can add a test e.g. to https://github.com/mamba-org/mamba/blob/master/test/micromamba/test_config.py or test_info.py

In that case we can create a .condarc file from Python, and then check what micromamba info returns.

Although there may be two problems:

  • not sure if micromamba info prints the channels currently (could be added)
  • and I think micromamba config list will just show the yaml config essentially

@wolfv
Copy link
Member

wolfv commented Oct 26, 2021

Ah well, I just saw your other PR! :)

@adriendelsalle adriendelsalle force-pushed the condarc-custom-multichannels branch from 9c7ec25 to 1860bf9 Compare October 26, 2021 14:22
@wolfv wolfv merged commit b50d820 into mamba-org:master Oct 26, 2021
@wolfv
Copy link
Member

wolfv commented Oct 26, 2021

We can fix the lint in another PR.

Thanks!

For the tests, we can do that in another PR, too :) Just wanted to get rid of the clutter from the refactoring.

@adriendelsalle adriendelsalle added this to the 2021.11.17 milestone Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Micromamba multichannel support
3 participants