Improve catching of reproc errors
#1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool! I am just wondering if we need these two simple functions. I think I would prefer to just use the constants directly in the code. |
|
I'm improving the |
wolfv
reviewed
Nov 3, 2021
catch reproc status indicating process killed or terminated use newly created assert_reproc_success function to check other pkgmgr calls throw an error only is no stop action could have killed or terminated the process remove reproc_killed and reproc_terminated from API link against reproc
adriendelsalle
force-pushed
the
fix-reproc-oom
branch
from
5c31399 to
3c86959
Compare
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve catching of
reprocerrors:REPROC_SIGKILLorREPROC_SIGTERMassert_reproc_successfunction to check other pkgmgr callsREPROC_SIGKILLorREPROC_SIGTERMas errors if (and only if) respectivelyreproc::stop::killorreproc::stop::terminatestop actions are not declared in asreproc::optionsIt will fix errors such as OOM-killed subprocess not caught (in Docker container or build for example).
See DaanDeMeyer/reproc#68
Closes #1100