-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mamba
log level
#1279
Fix mamba
log level
#1279
Conversation
Hmm this changes api completely which forces us to do a 0.19 release . It's not possible to keep the set verbosity which is common "conda lingo" |
I can keep the |
fa26958
to
4e32959
Compare
why can we not do the computations for loglevel inside c++ and have a simple set_verbosity function that handles this? I don't understand the need for all these complications and API changes. |
The For the user, nothing changed but the implementation has been improved to set So either I move that helper outside the |
It still breaks for users who have been using I don't mind the augmented API but I think it's not great to just change these things. |
For me verbosity and log level are also very much related. If I set a high verbosity I expect to see more logs. So for me it's a simplified way of just turning up the amount of logs that I see. setting verbosity should just increase logs across the board. setting log level can do that, but more specific to just mamba. We should also make sure that setting verbosity to |
It only concerns people using directly the Python bindings, and here I would say it's an improvement to decouple console verbosity and logs' one.
it's still the case
it's also the case when using |
Maybe the confusion is as follows:
So I would just extend the `set_verbosity function to also set log level as appropriate. |
add set_log_level method add python bindings for set_log_level and log levels enum use set_log_level in mamba
4e32959
to
3f0f918
Compare
Description
Fix
mamba
log level (both default and set from verbosity):Context
ctorset_verbosity
methodset_log_level
methodset_log_level
and log levels enum (spdlog::level::level_enum
)set_log_level
inmamba