Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cross-compilation builds #1976

Merged
merged 49 commits into from
Oct 4, 2022
Merged

Add cross-compilation builds #1976

merged 49 commits into from
Oct 4, 2022

Conversation

pavelzw
Copy link
Member

@pavelzw pavelzw commented Oct 2, 2022

  • Adds cross-compilation builds for linux-aarch64, linux-ppc64le and osx-arm64
  • Switches from custom compilation steps to conda-forge feedstock compilation steps
  • Remove Don't run this job branches because it is very slow in the Windows static build since the Windows static build takes about 30min (~22 with caching) which is still faster than the regular CI

I didn't manage to get the conda-build pipeline working for Windows in reasonable time and since we already have build instructions for Windows, I guess that's okay.

One issue we have is that the Linux and macOS builds don't use caching any more... But since they take less time than the regular CI pipeline even without caching, it should be okay...

Closes #1887

Copy link
Contributor

@jonashaag jonashaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice now. Thanks a bunch! Do you consider this ready to merge?

.github/workflows/static_build.yml Outdated Show resolved Hide resolved
@pavelzw
Copy link
Member Author

pavelzw commented Oct 4, 2022

Do you consider this ready to merge?

If you don't have anything more to add and the CI passes, you can merge it 👍🏻

@jonashaag
Copy link
Contributor

sed -z is a nice hack to do multiline replacements with sed :)

@jonashaag jonashaag merged commit b72fc93 into mamba-org:main Oct 4, 2022
@pavelzw
Copy link
Member Author

pavelzw commented Oct 4, 2022

sed -z is a nice hack to do multiline replacements with sed :)

Unfortunately only works on GNU sed :(

@jonashaag
Copy link
Contributor

It could be that we have gsed in the macOS runners. I think it's from the Homebrew coreutils package.

@pavelzw
Copy link
Member Author

pavelzw commented Oct 4, 2022

It could be that we have gsed in the macOS runners. I think it's from the Homebrew coreutils package.

Unfortunately not.

Hind-M pushed a commit to Hind-M/mamba that referenced this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fully static builds for all platforms
2 participants