Fix `micromamba env export` to get channel name instead of full url #2260

Hind-M · 2023-02-02T15:01:44Z

Fix #2235
In case of pkgs/main, defaults is used to be consistent with conda.

jonashaag · 2023-02-02T16:12:34Z

In case of pkgs/main, defaults is used to be consistent with conda.

Hmm... is this a special case in the Conda source code? If so, could you post a link to the piece of code that does it? I'm curious to see how exactly it is implemented.

Hind-M · 2023-02-06T16:18:31Z

Hmm... is this a special case in the Conda source code? If so, could you post a link to the piece of code that does it? I'm curious to see how exactly it is implemented.

Actually, I just run conda env export in a test environment which printed:

channels:
  - conda-forge
  - defaults

And looking at the Conda source code, I found this:
https://github.com/conda/conda/blob/fc92ea3353cce71df24fac31ce333ec9f8cf7ba7/tests/models/test_index_record.py#L30-L31
But didn't find the explicit implementation of it...

jonashaag · 2023-02-07T08:12:12Z

I'd be interested if Conda always prints the name of the channel that has been used to install (like --from-history), or the name of the multichannel.

AntoinePrv · 2023-02-09T11:20:13Z

micromamba/src/env.cpp

+                    if (chan_name == "pkgs/main")
+                    {
+                        channels.insert("defaults");
+                    }


It looks like using either pkgs/main or defaults works so I would be conservative and say we do not need to change? I'm no expert here. What do you think?

In the refactorign reflection, this should go in Channel, eventually through a new method name like cannonical_name so that we don't manage edge cases everywhere.

Yes we could leave pkgs/main then (less prone to bugs and avoid edge cases). And yes, I agree that we should use something like canonical_name like Conda does IIRC.

AntoinePrv · 2023-02-09T11:20:28Z

micromamba/tests/test_env.py

@@ -120,7 +120,7 @@ def test_env_export(self):
        create("", "-n", env_name, "-f", spec_file)
        ret = yaml.safe_load(run_env("export", "-n", env_name))
        assert ret["name"] == env_name
-        assert set(ret["channels"]) == {"https://conda.anaconda.org/conda-forge"}
+        assert set(ret["channels"]) == {"conda-forge"}


If we do add that the defaults naming, we should also add a test for it, so that we do not loose it through a refactoring.

jonashaag · 2023-02-09T15:54:30Z

I'd be interested if Conda always prints the name of the channel that has been used to install (like --from-history), or the name of the multichannel.

Did anyone check this?

Hind-M · 2023-02-09T16:46:18Z

I'd be interested if Conda always prints the name of the channel that has been used to install (like --from-history), or the name of the multichannel.

Did anyone check this?

Nope. I've looked a bit into their code base but it wasn't obvious to spot and have the full picture. I would probably spend more time on it later if no one else checks it or has already some prior background to narrow the search.

jonashaag · 2023-02-09T16:51:19Z

OK! Should we wait until we have a definite answer? I guess solving this issue isn't urgent, and if we change behavior twice that might be confusing to users.

Hind-M · 2023-02-09T16:54:27Z

Yes, that seems reasonable!

jonashaag · 2023-02-16T09:32:29Z

I had a look:

$ cat ~/.condarc
channels:
- defaults
- conda-forge

custom_multichannels:
  my_multi:
  - conda-forge

$ mamba create -n t1 conda-forge::zlib
$ mamba create -n t2 defaults::zlib  # => does not work
$ mamba create -n t2 pkgs/main::zlib
$ mamba create -n t3 my_multi::zlib

$ conda env export -n t1
name: t1
channels:
  - my_multi
  - defaults
  - conda-forge
...

$ conda env export -n t2
name: t2
channels:
  - defaults
  - conda-forge
  # => NOTE: No my_multi
...

$ conda env export -n t3
name: t3
channels:
  - my_multi
  - defaults
  - conda-forge
...

$ micromamba env export -p /opt/conda/envs/t1
name:
channels:
- https://conda.anaconda.org/conda-forge
- https://repo.anaconda.com/pkgs/main
# => NOTE: No my_multi, but mamba env export has it
...

$ micromamba env export -p /opt/conda/envs/t2
name:
channels:
- https://repo.anaconda.com/pkgs/main
# => NOTE: No conda-forge and my_multi, but mamba env export have it
...

$ micromamba env export -p /opt/conda/envs/t3
name:
channels:
- https://conda.anaconda.org/conda-forge
- https://repo.anaconda.com/pkgs/main
# => NOTE: No my_multi, but mamba env export has it
...

Now with --from-history:

$ conda env export -n t1 --from-history
name: t1
channels:
  - defaults
  - conda-forge
dependencies:
  - conda-forge::zlib
prefix: /opt/conda/envs/t1

$ conda env export -n t2 --from-history
name: t2
channels:
  - defaults
  - conda-forge
dependencies:
  - pkgs/main::zlib
prefix: /opt/conda/envs/t2

$ conda env export -n t3 --from-history
name: t3
channels:
  - defaults
  - conda-forge
dependencies:
  - my_multi::zlib
prefix: /opt/conda/envs/t3

$ micromamba env export -p /opt/conda/envs/t1 --from-history
name:
channels:
- https://conda.anaconda.org/conda-forge
# => NOTE: No defaults, but mamba env export has it
dependencies:
- conda-forge::zlib

$ micromamba env export -p /opt/conda/envs/t2 --from-history
name:
channels:
- https://repo.anaconda.com/pkgs/main
# => NOTE: No conda-forge, but mamba env export has it
dependencies:
- pkgs/main::zlib

$ micromamba env export -p /opt/conda/envs/t3 --from-history
name:
channels:
- https://conda.anaconda.org/conda-forge
# => NOTE: No defaults, but mamba env export has it
dependencies:
- my_multi::zlib

IIUC we should always print the multichannel name in channels:, and not special-case defaults.

jonashaag · 2023-02-16T09:35:14Z

Interestingly, the order of channels is different with Micromamba. Is that a bug? cc @wolfv

Hind-M · 2023-02-20T16:07:29Z

Thanks!
So, it looks like using pkgs/main over defaults is the way to go indeed mainly because of this:

$ mamba create -n t2 defaults::zlib # => does not work

But I still find the general logic not that clear:

When using --from-history, the printed channels should be the ones used explicitly when getting packages, so the behavior of micromamba seems more logical to me (should we just follow conda's behavior for consistency?).
This is how other channels are inserted when exporting without the from-history flag, and (when ignore_channels flag is set to False (default). Note that this flag doesn't exist in micromamba apparently):
https://github.com/conda/conda/blob/main/conda_env/env.py#L128-L133
Otherwise, when exporting without any flags, I'm wondering if conda considers the condarc file and only prints custom_multichannels if they match the ones used when getting packages? (prints my_multi only because it's set to conda-forge and when the package is requested from there).

But anyway, I think that any other changes should be done in other PRs since they would be considered as additional features (handle custom_multichannels and the other missing ones).

jonashaag

Agreed!

Fix micromamba env export to get channel name instead of full url

924dac6

AntoinePrv reviewed Feb 9, 2023

View reviewed changes

Use pkgs/main instead of defaults as channel name

bfe45de

AntoinePrv approved these changes Feb 9, 2023

View reviewed changes

jonashaag mentioned this pull request Feb 16, 2023

micromamba env export -p does not include env name #2296

Open

2 tasks

jonashaag approved these changes Feb 21, 2023

View reviewed changes

Hind-M mentioned this pull request Feb 21, 2023

[Micromamaba] Add missing --ignore-channels flag in env export command #2313

Open

Hind-M merged commit f279b48 into mamba-org:main Feb 22, 2023

JohanMabille assigned Hind-M Feb 22, 2023

jonashaag mentioned this pull request Mar 31, 2023

Cannot use defaults::* match specs in the CLI #2431

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `micromamba env export` to get channel name instead of full url #2260

Fix `micromamba env export` to get channel name instead of full url #2260

Hind-M commented Feb 2, 2023

jonashaag commented Feb 2, 2023

Hind-M commented Feb 6, 2023 •

edited

Loading

jonashaag commented Feb 7, 2023

AntoinePrv Feb 9, 2023

Hind-M Feb 9, 2023

AntoinePrv Feb 9, 2023

Hind-M Feb 9, 2023

jonashaag commented Feb 9, 2023

Hind-M commented Feb 9, 2023

jonashaag commented Feb 9, 2023

Hind-M commented Feb 9, 2023

jonashaag commented Feb 16, 2023

jonashaag commented Feb 16, 2023

Hind-M commented Feb 20, 2023

jonashaag left a comment

Fix micromamba env export to get channel name instead of full url #2260

Fix micromamba env export to get channel name instead of full url #2260

Conversation

Hind-M commented Feb 2, 2023

jonashaag commented Feb 2, 2023

Hind-M commented Feb 6, 2023 • edited Loading

jonashaag commented Feb 7, 2023

AntoinePrv Feb 9, 2023

Choose a reason for hiding this comment

Hind-M Feb 9, 2023

Choose a reason for hiding this comment

AntoinePrv Feb 9, 2023

Choose a reason for hiding this comment

Hind-M Feb 9, 2023

Choose a reason for hiding this comment

jonashaag commented Feb 9, 2023

Hind-M commented Feb 9, 2023

jonashaag commented Feb 9, 2023

Hind-M commented Feb 9, 2023

jonashaag commented Feb 16, 2023

jonashaag commented Feb 16, 2023

Hind-M commented Feb 20, 2023

jonashaag left a comment

Choose a reason for hiding this comment

Fix `micromamba env export` to get channel name instead of full url #2260

Fix `micromamba env export` to get channel name instead of full url #2260

Hind-M commented Feb 6, 2023 •

edited

Loading