Add channel specific job with new str #2277
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, using a spec like
conda-forge::python
will segfault inMSolver::all_problems_structured
because channel specific jobs are added as a queue qith SOLVER_JOB_ONE_OF. Inall_prblem_structured
, the queueid
is popping back as adep
but isn't.There is not easy way to check for it explicitly, and no way to kepp track of the the fact that it was an explicit channel job.
The fix proposed here is rather to change the implementation of
add_channel_specific_jobs
to dynamically add a spec for the channel specific spec.