Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add strip_if functions #2344

Merged
merged 6 commits into from
Mar 8, 2023
Merged

Add strip_if functions #2344

merged 6 commits into from
Mar 8, 2023

Conversation

AntoinePrv
Copy link
Member

@AntoinePrv AntoinePrv commented Mar 3, 2023 •
edited
Loading

@AntoinePrv AntoinePrv mentioned this pull request Mar 3, 2023
Merged
6 tasks
@AntoinePrv AntoinePrv mentioned this pull request Mar 3, 2023
Closed
1 task
@AntoinePrv AntoinePrv force-pushed the util-string-strip-if branch from 09b965f to 0d6ec27 Compare March 3, 2023 15:45
@AntoinePrv AntoinePrv marked this pull request as ready for review March 3, 2023 15:45
@AntoinePrv AntoinePrv requested a review from JohanMabille March 3, 2023 15:45
@AntoinePrv AntoinePrv force-pushed the util-string-strip-if branch from 0d6ec27 to 55630e2 Compare March 3, 2023 17:10
@AntoinePrv AntoinePrv requested a review from Hind-M March 6, 2023 09:01
Hind-M
Hind-M reviewed Mar 6, 2023
View reviewed changes
libmamba/include/mamba/core/util_string.hpp Outdated Show resolved Hide resolved
libmamba/src/core/util_string.cpp Outdated Show resolved Hide resolved
@AntoinePrv AntoinePrv requested a review from Hind-M March 6, 2023 10:44
JohanMabille and others added 2 commits March 8, 2023 09:16
@JohanMabille @AntoinePrv
Update libmamba/src/core/util_string.cpp
b161a8b 
Co-authored-by: Antoine Prouvost <AntoinePrv@users.noreply.github.com>
@JohanMabille
Merge branch 'main' into util-string-strip-if
7f9b2f2
@JohanMabille JohanMabille merged commit 5758ca2 into mamba-org:main Mar 8, 2023
@AntoinePrv AntoinePrv deleted the util-string-strip-if branch March 8, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hind-M Hind-M Hind-M approved these changes

@JohanMabille JohanMabille Awaiting requested review from JohanMabille

Assignees
No one assigned
Labels
type::general-improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AntoinePrv @JohanMabille @Hind-M