-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First version/steps of unraveling fetch
code and wrapping libcurl
#2376
Conversation
This one can be rebased now that #2366 has been merged |
libmamba/src/core/curl.cpp
Outdated
} | ||
} | ||
|
||
const std::pair<std::string_view, CurlLogLevel> CURLHandle::init_curl_ssl_session() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the name is misleading, this function does not initialize anything but simply get info about the ssl backend. Maybe get_ssl_backend_info
would be a better name.
Regarding the implementation, I think it should return info->backend instead of a string_view with a log, and have a log function performing the switch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the implementation, I think it should return info->backend instead of a string_view with a log, and have a log function performing the switch.
Yes exactly, that's why I did it this way until we decide what we do with logging (I left curl specific code inside on purpose, but that's a way among others of doing it). I added an explicit comment though for later...
Part of #2356 fix
Based on #2366