TimeRef is not a singleton anymore. #2396
Conversation
Klaim
force-pushed
the
klaim/context-not-singleton
branch
from
2ccebbd to
05630ac
Compare
|
Note: I moved the |
| #include <chrono> | ||
| #include <string> | ||
|
|
||
| namespace validate |
There was a problem hiding this comment.
Should we scope that with mamba::? I've started following that convention with mamba::solv, mamba::util...
There was a problem hiding this comment.
+1 on scoping inner namespaces with mamba::
There was a problem hiding this comment.
It's the namespace that is originally in validate.hpp/cpp 😬
If that's ok with yall I'll change it to mamba::validate in a separate PR
| #include <chrono> | ||
| #include <string> | ||
|
|
||
| namespace validate |
There was a problem hiding this comment.
+1 on scoping inner namespaces with mamba::
libmamba/src/core/timeref.cpp
Outdated
| { | ||
| } | ||
|
|
||
| TimeRef::~TimeRef() = default; |
There was a problem hiding this comment.
I think we can rely on destructor automatic generation and remove this line and its declaration in the header.
| @@ -711,11 +711,11 @@ namespace validate | |||
| RootImpl root(root1_json); | |||
|
|
|||
| // expiration is set to now+3600s in 'sign_root' | |||
| TimeRef::instance().set(utc_time_now()); | |||
| EXPECT_FALSE(root.expired()); | |||
| auto time_ref = TimeRef{ utc_time_now() }; | |||
There was a problem hiding this comment.
Nitpicking: TimeRef time_ref;
Klaim
force-pushed
the
klaim/context-not-singleton
branch
from
05630ac to
7606275
Compare
No description provided.