-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated to doctest #2436
Migrated to doctest #2436
Conversation
6282f36
to
02abcac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bd2eab8
to
1088f0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! I'm looking forward to nicer testing!
I mostly checked the test I wrote and everything looks good.
#include "mamba/core/activation.hpp" | ||
|
||
#include "doctest/doctest.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
#include "doctest/doctest.h" | |
#include <doctest/doctest.h> |
|| std::holds_alternative<ProblemsGraph::ConstraintNode>(g.node(n)) | ||
); | ||
} | ||
std::vector<decltype(&create_basic_conflict)> pb_values = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: std::array
} | ||
|
||
TEST_P(Problem, simplify_conflicts) | ||
TEST_SUITE("satifiability_error") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a mental note to come back on this test to share the resources without static
. We have ~10 static Pools here so 10x repodata.json
b750481
to
720e724
Compare
No description provided.