Wapped curl multi handle #2459
Wapped curl multi handle #2459
Conversation
JohanMabille
force-pushed
the
multi_handle
branch
from
5bb7893 to
43db0ba
Compare
| * CURLReference * | ||
| *****************/ | ||
|
|
||
| CURLReference::CURLReference(CURL* handle) |
There was a problem hiding this comment.
Note that in other wrappers we have been using .raw()
There was a problem hiding this comment.
Oups, this should be pointing at the unwrap line, sorry
|
|
||
| CURLMultiHandle& CURLMultiHandle::operator=(CURLMultiHandle&& rhs) | ||
| { | ||
| std::swap(p_handle, rhs.p_handle); |
There was a problem hiding this comment.
Shouldnt we set rhs in a non-owning state? Just swapping here will make it own what we have, it might not be immediately destroyed.
There was a problem hiding this comment.
It's ok to have rhs freeing the curl handle in its destructor later.
There was a problem hiding this comment.
Yeah but is it ok if it's not called immediately and rhs is still a valid usable object and is used before being destroyed?
There was a problem hiding this comment.
Yes, the object it is swapped with is in a valid state as soon as it has been constructed.
JohanMabille
force-pushed
the
multi_handle
branch
2 times, most recently
from
d50d03b to
6b243e1
Compare
No description provided.