[Libcurl] Cleaning and comments #2534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
reviewed
May 17, 2023
| if (res) | ||
| { | ||
| return static_cast<I>(res.value()); | ||
| return static_cast<std::size_t>(res.value()); |
There was a problem hiding this comment.
I maybe should've asked earlier but isn't casting to size_t a mistake since before it was a signed integer?
There was a problem hiding this comment.
Because it's used to set speed and m_downloaded_size which are eventually converted to std::size_t in set_speed, update_progress and set_total of the ProgressBar...
These notions with m_retry_wait_seconds are also intuitively representing something that should be unsigned... I wonder why it's not handled in libcurl that way btw...
There was a problem hiding this comment.
Maybe they use negative values for errors.
There was a problem hiding this comment.
If that's the case, we should check the return value and return the appropriate tl::unexpected.
JohanMabille
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.