use ObjTransaction in MTransaction #2565

AntoinePrv · 2023-06-05T13:53:14Z

libmamba/src/core/transaction.cpp

AntoinePrv self-assigned this Jun 5, 2023

AntoinePrv added type::general-improvement where::libsolv type::refactoring labels Jun 5, 2023

AntoinePrv force-pushed the solv-use-transaction branch 5 times, most recently from 85d90d7 to b71989c Compare June 8, 2023 09:14

AntoinePrv added 10 commits June 9, 2023 12:45

Libsolv wrappers improvements

0755a85

Make ObjRepoViewConst constructible from solvable

6f2b0f0

Add ObjPool installed solvable iteration

87d4548

Fix compilation warning

93fd516

Make MSolver::solver public

ef7e07e

Make internal MRepo methods private

2a3eef8

Replace MTransaction::m_transaction with ObjTransaction

0135779

Build history request eagerly in MTransaction

3ba3a12

Use ObjTransactio wrapper in MTransaction

531cd1a

Default ~ObjDestructor

6d68895

AntoinePrv force-pushed the solv-use-transaction branch from b71989c to 6d68895 Compare June 9, 2023 10:45

AntoinePrv marked this pull request as ready for review June 9, 2023 10:54

AntoinePrv requested review from Klaim and JohanMabille June 9, 2023 10:55

JohanMabille reviewed Jun 12, 2023

View reviewed changes

libmamba/src/core/transaction.cpp Outdated Show resolved Hide resolved

libmamba/src/core/transaction.cpp Outdated Show resolved Hide resolved

Improve copy in make_pkg_info_from_explicit_match_specs

2c352cd

AntoinePrv requested a review from JohanMabille June 12, 2023 13:54

JohanMabille approved these changes Jun 12, 2023

View reviewed changes

AntoinePrv merged commit d452142 into mamba-org:main Jun 13, 2023

AntoinePrv deleted the solv-use-transaction branch June 13, 2023 08:52

Provide feedback