Create Solver solution #2584
Merged
Create Solver solution #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoinePrv
force-pushed
the
solv-solution
branch
3 times, most recently
from
4f31204 to
91b3725
Compare
AntoinePrv
force-pushed
the
solv-solution
branch
2 times, most recently
from
45ad4bd to
199d3cd
Compare
AntoinePrv
force-pushed
the
solv-solution
branch
from
199d3cd to
70598b8
Compare
AntoinePrv
force-pushed
the
solv-solution
branch
2 times, most recently
from
ae35d70 to
e204a93
Compare
Klaim
reviewed
Jun 27, 2023
AntoinePrv
force-pushed
the
solv-solution
branch
2 times, most recently
from
423dcfa to
2327d40
Compare
Klaim
approved these changes
Jul 3, 2023
JohanMabille
requested changes
Jul 3, 2023
| namespace detail | ||
| { | ||
| template <typename Action> | ||
| auto to_remove_ptr(Action& action) |
There was a problem hiding this comment.
Why a template here? From the std::visit in the implementation, it looks like you are operating on the type Action defined here
There was a problem hiding this comment.
Maybe this is not the idiomatic way of doing this, but this was to deduce the constness of Action, used to deduce the constness of the returned pointer.
| namespace detail | ||
| { | ||
| template <typename Action> | ||
| auto to_install_ptr(Action& action) |
| namespace detail | ||
| { | ||
| template <typename Action> | ||
| auto to_omit_ptr(Action& action) |
There was a problem hiding this comment.
Same remark as previous regarding the template
JohanMabille
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
Solutionclass represents the outcome of a Solver solve, which is now help inside a::Transaction*.This PR introduce slowly start rolling it out in
mamba::MTransaction.The
MSolverflags are also refactored into astruct.Other transitory changes are added.