Add missing cstdint include to libmamba/src/solv-cpp/solvable.cpp #2587

maxyvisser · 2023-06-13T05:57:47Z

The micromamba package in the AUR fails to build with the following errors:

/compile/makepkg/micromamba/src/mamba-2023.05.16/libmamba/src/solv-cpp/solvable.cpp:153:81: error: ‘uint64_t’ is not a member of ‘std’; did you mean ‘wint_t’?
  153 |             std::numeric_limits<decltype(n)>::max() <= std::numeric_limits<std::uint64_t>::max()
      |                                                                                 ^~~~~~~~
      |                                                                                 wint_t
/compile/makepkg/micromamba/src/mamba-2023.05.16/libmamba/src/solv-cpp/solvable.cpp:153:89: error: template argument 1 is invalid
  153 |             std::numeric_limits<decltype(n)>::max() <= std::numeric_limits<std::uint64_t>::max()
      |                                                                                         ^

This pr adds the missing import (cstdint), and it now builds correctly on Archlinux.

Is anyone willing to check this for potential problems?

JohanMabille · 2023-06-13T07:33:03Z

Thanks for the fix. Would you mind running the linter locally to fix it? The libmamba_cpp_tests_win failure is unrelated to this PR.

maxyvisser · 2023-06-13T15:49:27Z

Thanks for the fix. Would you mind running the linter locally to fix it? The libmamba_cpp_tests_win failure is unrelated to this PR.

I'm sorry, I don't have much experience with C++, mamba or github. I'm just an Arch user trying to fix a build issue. Would you mind explaining which linter to run and how to run it locally?

maxyvisser · 2023-06-13T17:52:41Z

Through trial and a lot of error, I managed to get the attached output from clang-tidy libmamba/src/solv-cpp/solvable.cpp -checks="*" --fix > clang-tidy.txt. None of the errors appear to be caused by this commit: reverting the commit and running diff on the outputs shows that the commit only causes some warnings:

18,24d17
< /home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:9:1: warning: #includes are not sorted properly [llvm-include-order]
< #include <cstdint>
< ^
< note: this fix will not be applied because it overlaps with another fix
< /home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:9:1: warning: system include cstdint not allowed [llvmlibc-restrict-system-libc-headers]
< #include <cstdint>
< ^~~~~~~~~~~~~~~~~~
133,147d125
< /home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:154:13: warning: 'max' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
<             std::numeric_limits<decltype(n)>::max() <= std::numeric_limits<std::uint64_t>::max()
<             ^
< /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/13.1.1/../../../../include/c++/13.1.1/limits:1274:7: note: resolves to this declaration
<       max() _GLIBCXX_USE_NOEXCEPT { return __LONG_MAX__ * 2UL + 1; }
<       ^
< /home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:154:53: warning: both sides of operator are equivalent [misc-redundant-expression]
<             std::numeric_limits<decltype(n)>::max() <= std::numeric_limits<std::uint64_t>::max()
<                                                     ^
< /home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:154:56: warning: 'max' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
<             std::numeric_limits<decltype(n)>::max() <= std::numeric_limits<std::uint64_t>::max()
<                                                        ^
< /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/13.1.1/../../../../include/c++/13.1.1/limits:1274:7: note: resolves to this declaration
<       max() _GLIBCXX_USE_NOEXCEPT { return __LONG_MAX__ * 2UL + 1; }
<       ^

Here is the full output of clang-tidy libmamba/src/solv-cpp/solvable.cpp -checks="*" --fix > clang-tidy.txt with the patch:

error: too many errors emitted, stopping now [clang-diagnostic-error]
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/queue.hpp:130:28: error: no template named 'is_same_v' in namespace 'std'; did you mean 'is_same'? [clang-diagnostic-error]
        if constexpr (std::is_same_v<InputIt, iterator> || std::is_same_v<InputIt, const_iterator>)
                      ~~~~~^~~~~~~~~
                           is_same
/usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/13.1.1/../../../../include/c++/13.1.1/type_traits:1393:12: note: 'is_same' declared here
    struct is_same
           ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/queue.hpp:130:57: error: expected unqualified-id [clang-diagnostic-error]
        if constexpr (std::is_same_v<InputIt, iterator> || std::is_same_v<InputIt, const_iterator>)
                                                        ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:7:1: warning: system include array not allowed [llvmlibc-restrict-system-libc-headers]
#include <array>
^~~~~~~~~~~~~~~~
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:8:1: warning: system include cassert not allowed [llvmlibc-restrict-system-libc-headers]
#include <cassert>
^~~~~~~~~~~~~~~~~~
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:9:1: warning: #includes are not sorted properly [llvm-include-order]
#include <cstdint>
^
note: this fix will not be applied because it overlaps with another fix
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:9:1: warning: system include cstdint not allowed [llvmlibc-restrict-system-libc-headers]
#include <cstdint>
^~~~~~~~~~~~~~~~~~
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:10:1: warning: system include charconv not allowed [llvmlibc-restrict-system-libc-headers]
#include <charconv>
^~~~~~~~~~~~~~~~~~~
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:11:1: warning: system include limits not allowed [llvmlibc-restrict-system-libc-headers]
#include <limits>
^~~~~~~~~~~~~~~~~
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:13:1: warning: system include solv/knownid.h not allowed [llvmlibc-restrict-system-libc-headers]
#include <solv/knownid.h>
^~~~~~~~~~~~~~~~~~~~~~~~~
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:14:1: warning: system include solv/pool.h not allowed [llvmlibc-restrict-system-libc-headers]
#include <solv/pool.h>
^~~~~~~~~~~~~~~~~~~~~~
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:15:1: warning: system include solv/repo.h not allowed [llvmlibc-restrict-system-libc-headers]
#include <solv/repo.h>
^~~~~~~~~~~~~~~~~~~~~~
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:16:1: warning: system include solv/solvable.h not allowed [llvmlibc-restrict-system-libc-headers]
#include <solv/solvable.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:20:11: warning: '__llvm_libc' needs to be the outermost namespace [llvmlibc-implementation-in-namespace]
namespace mamba::solv
          ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:20:16: warning: nested namespace definition is a C++17 extension; define each namespace separately [clang-diagnostic-c++17-extensions]
namespace mamba::solv
               ^~~~~~
                { namespace solv
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:36:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableViewConst::raw() const -> const ::Solvable*
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:41:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableViewConst::id() const -> SolvableId
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:43:16: warning: 'pool_solvable2id' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        return ::pool_solvable2id(raw()->repo->pool, const_cast<::Solvable*>(raw()));
               ^
/usr/include/solv/pool.h:290:18: note: resolves to this declaration
static inline Id pool_solvable2id(const Pool *pool, Solvable *s)
                 ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:43:54: warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]
        return ::pool_solvable2id(raw()->repo->pool, const_cast<::Solvable*>(raw()));
                                                     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:55:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableView::raw() const -> ::Solvable*
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:58:16: warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]
        return const_cast<::Solvable*>(ObjSolvableViewConst::raw());
               ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:68:9: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
        auto ptr_to_strview(const char* ptr) -> std::string_view
        ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:68:54: error: no type named 'string_view' in namespace 'std' [clang-diagnostic-error]
        auto ptr_to_strview(const char* ptr) -> std::string_view
                                                ~~~~~^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:70:35: error: no type named 'string_view' in namespace 'std' [clang-diagnostic-error]
            static constexpr std::string_view null = "<NULL>";
                             ~~~~~^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:87:24: warning: variable name 'id' is too short, expected at least 3 characters [readability-identifier-length]
            const ::Id id = ::pool_strn2id(
                       ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:87:29: warning: 'pool_strn2id' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
            const ::Id id = ::pool_strn2id(
                            ^
/usr/include/solv/poolid.h:34:11: note: resolves to this declaration
extern Id pool_strn2id(Pool *pool, const char *, unsigned int, int);
          ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:96:5: warning: anonymous namespace not terminated with a closing comment [google-readability-namespace-comments,llvm-namespace-comment]
    }
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:67:5: note: anonymous namespace starts here
    {
    ^
note: cannot apply fix-it because an alias checker has suggested a different fix-it; please remove one of the checkers ('google-readability-namespace-comments', 'llvm-namespace-comment') or ensure they are both configured the same
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:98:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableViewConst::name() const -> std::string_view
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:103:45: warning: parameter name 'id' is too short, expected at least 3 characters [readability-identifier-length]
    void ObjSolvableView::set_name(StringId id) const
                                            ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:105:9: warning: 'solvable_set_id' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        ::solvable_set_id(raw(), SOLVABLE_NAME, id);
        ^
/usr/include/solv/solvable.h:83:6: note: resolves to this declaration
void solvable_set_id(Solvable *s, Id keyname, Id id);
     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:113:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableViewConst::version() const -> std::string_view
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:118:48: warning: parameter name 'id' is too short, expected at least 3 characters [readability-identifier-length]
    void ObjSolvableView::set_version(StringId id) const
                                               ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:120:9: warning: 'solvable_set_id' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        ::solvable_set_id(raw(), SOLVABLE_EVR, id);
        ^
/usr/include/solv/solvable.h:83:6: note: resolves to this declaration
void solvable_set_id(Solvable *s, Id keyname, Id id);
     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:131:9: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
        auto to_int_or(std::string_view str, Int val) -> Int
        ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:136:5: warning: anonymous namespace not terminated with a closing comment [llvm-namespace-comment]
    }
    ^
      // namespace
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:129:5: note: anonymous namespace starts here
    {
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:138:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableViewConst::build_number() const -> std::size_t
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:154:13: warning: 'max' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
            std::numeric_limits<decltype(n)>::max() <= std::numeric_limits<std::uint64_t>::max()
            ^
/usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/13.1.1/../../../../include/c++/13.1.1/limits:1274:7: note: resolves to this declaration
      max() _GLIBCXX_USE_NOEXCEPT { return __LONG_MAX__ * 2UL + 1; }
      ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:154:53: warning: both sides of operator are equivalent [misc-redundant-expression]
            std::numeric_limits<decltype(n)>::max() <= std::numeric_limits<std::uint64_t>::max()
                                                    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:154:56: warning: 'max' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
            std::numeric_limits<decltype(n)>::max() <= std::numeric_limits<std::uint64_t>::max()
                                                       ^
/usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/13.1.1/../../../../include/c++/13.1.1/limits:1274:7: note: resolves to this declaration
      max() _GLIBCXX_USE_NOEXCEPT { return __LONG_MAX__ * 2UL + 1; }
      ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:163:9: warning: 'solvable_set_str' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        ::solvable_set_str(raw(), SOLVABLE_BUILDVERSION, str.data());
        ^
/usr/include/solv/solvable.h:85:6: note: resolves to this declaration
void solvable_set_str(Solvable *s, Id keyname, const char *str);
     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:166:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableViewConst::build_string() const -> std::string_view
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:178:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableViewConst::file_name() const -> std::string_view
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:184:54: warning: parameter name 'fn' is too short, expected at least 3 characters [readability-identifier-length]
    void ObjSolvableView::set_file_name(raw_str_view fn) const
                                                     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:186:9: warning: missing username/bug in TODO [google-readability-todo]
        // TODO would like to use ``repodata_set_strn`` or similar but it is not visible
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        // TODO(maxy): would like to use ``repodata_set_strn`` or similar but it is not visible
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:187:9: warning: 'solvable_set_str' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        ::solvable_set_str(raw(), SOLVABLE_MEDIAFILE, fn);
        ^
/usr/include/solv/solvable.h:85:6: note: resolves to this declaration
void solvable_set_str(Solvable *s, Id keyname, const char *str);
     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:190:60: warning: parameter name 'fn' is too short, expected at least 3 characters [readability-identifier-length]
    void ObjSolvableView::set_file_name(const std::string& fn) const
                                                           ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:195:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableViewConst::license() const -> std::string_view
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:202:9: warning: 'solvable_set_str' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        ::solvable_set_str(raw(), SOLVABLE_LICENSE, str);
        ^
/usr/include/solv/solvable.h:85:6: note: resolves to this declaration
void solvable_set_str(Solvable *s, Id keyname, const char *str);
     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:210:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableViewConst::md5() const -> std::string_view
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:213:28: warning: 'solvable_lookup_checksum' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        const char* hash = ::solvable_lookup_checksum(
                           ^
/usr/include/solv/solvable.h:77:13: note: resolves to this declaration
const char *solvable_lookup_checksum(Solvable *s, Id keyname, Id *typep);
            ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:214:13: warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]
            const_cast<::Solvable*>(raw()),
            ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:225:9: warning: 'repodata_set_checksum' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        ::repodata_set_checksum(
        ^
/usr/include/solv/repodata.h:279:6: note: resolves to this declaration
void repodata_set_checksum(Repodata *data, Id solvid, Id keyname, Id type,
     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:226:13: warning: 'repo_last_repodata' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
            ::repo_last_repodata(repo),
            ^
/usr/include/solv/repo.h:171:11: note: resolves to this declaration
Repodata *repo_last_repodata(Repo *repo);
          ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:227:13: warning: 'pool_solvable2id' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
            ::pool_solvable2id(repo->pool, raw()),
            ^
/usr/include/solv/pool.h:290:18: note: resolves to this declaration
static inline Id pool_solvable2id(const Pool *pool, Solvable *s)
                 ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:239:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableViewConst::noarch() const -> std::string_view
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:248:9: warning: 'solvable_set_str' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        ::solvable_set_str(raw(), SOLVABLE_SOURCEARCH, str);
        ^
/usr/include/solv/solvable.h:85:6: note: resolves to this declaration
void solvable_set_str(Solvable *s, Id keyname, const char *str);
     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:256:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableViewConst::sha256() const -> std::string_view
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:259:28: warning: 'solvable_lookup_checksum' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        const char* hash = ::solvable_lookup_checksum(
                           ^
/usr/include/solv/solvable.h:77:13: note: resolves to this declaration
const char *solvable_lookup_checksum(Solvable *s, Id keyname, Id *typep);
            ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:260:13: warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]
            const_cast<::Solvable*>(raw()),
            ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:271:9: warning: 'repodata_set_checksum' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        ::repodata_set_checksum(
        ^
/usr/include/solv/repodata.h:279:6: note: resolves to this declaration
void repodata_set_checksum(Repodata *data, Id solvid, Id keyname, Id type,
     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:272:13: warning: 'repo_last_repodata' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
            ::repo_last_repodata(repo),
            ^
/usr/include/solv/repo.h:171:11: note: resolves to this declaration
Repodata *repo_last_repodata(Repo *repo);
          ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:273:13: warning: 'pool_solvable2id' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
            ::pool_solvable2id(repo->pool, raw()),
            ^
/usr/include/solv/pool.h:290:18: note: resolves to this declaration
static inline Id pool_solvable2id(const Pool *pool, Solvable *s)
                 ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:285:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableViewConst::size() const -> std::size_t
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:287:16: warning: 'solvable_lookup_num' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        return ::solvable_lookup_num(const_cast<::Solvable*>(raw()), SOLVABLE_DOWNLOADSIZE, 0);
               ^
/usr/include/solv/solvable.h:66:20: note: resolves to this declaration
unsigned long long solvable_lookup_num(Solvable *s, Id keyname, unsigned long long notfound);
                   ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:287:38: warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]
        return ::solvable_lookup_num(const_cast<::Solvable*>(raw()), SOLVABLE_DOWNLOADSIZE, 0);
                                     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:292:9: warning: 'solvable_set_num' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        ::solvable_set_num(raw(), SOLVABLE_DOWNLOADSIZE, n);
        ^
/usr/include/solv/solvable.h:84:6: note: resolves to this declaration
void solvable_set_num(Solvable *s, Id keyname, unsigned long long num);
     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:295:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableViewConst::timestamp() const -> std::size_t
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:297:16: warning: 'solvable_lookup_num' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        return ::solvable_lookup_num(const_cast<::Solvable*>(raw()), SOLVABLE_BUILDTIME, 0);
               ^
/usr/include/solv/solvable.h:66:20: note: resolves to this declaration
unsigned long long solvable_lookup_num(Solvable *s, Id keyname, unsigned long long notfound);
                   ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:297:38: warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]
        return ::solvable_lookup_num(const_cast<::Solvable*>(raw()), SOLVABLE_BUILDTIME, 0);
                                     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:302:9: warning: 'solvable_set_num' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        ::solvable_set_num(raw(), SOLVABLE_BUILDTIME, n);
        ^
/usr/include/solv/solvable.h:84:6: note: resolves to this declaration
void solvable_set_num(Solvable *s, Id keyname, unsigned long long num);
     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:305:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableViewConst::url() const -> std::string_view
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:312:9: warning: 'solvable_set_str' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        ::solvable_set_str(raw(), SOLVABLE_URL, str);
        ^
/usr/include/solv/solvable.h:85:6: note: resolves to this declaration
void solvable_set_str(Solvable *s, Id keyname, const char *str);
     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:320:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableViewConst::channel() const -> std::string_view
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:328:9: warning: 'solvable_set_str' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        ::solvable_set_str(raw(), SOLVABLE_PACKAGER, str);
        ^
/usr/include/solv/solvable.h:85:6: note: resolves to this declaration
void solvable_set_str(Solvable *s, Id keyname, const char *str);
     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:336:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableViewConst::subdir() const -> std::string_view
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:344:9: warning: 'solvable_set_str' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        ::solvable_set_str(raw(), SOLVABLE_MEDIADIR, str);
        ^
/usr/include/solv/solvable.h:85:6: note: resolves to this declaration
void solvable_set_str(Solvable *s, Id keyname, const char *str);
     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:352:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableViewConst::dependencies() const -> ObjQueue
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:354:14: warning: variable name 'q' is too short, expected at least 3 characters [readability-identifier-length]
        auto q = ObjQueue{};
             ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:355:9: warning: 'solvable_lookup_deparray' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        ::solvable_lookup_deparray(
        ^
/usr/include/solv/solvable.h:79:5: note: resolves to this declaration
int solvable_lookup_deparray(Solvable *s, Id keyname, Queue *q, Id marker);
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:356:13: warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]
            const_cast<::Solvable*>(raw()),
            ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:364:60: warning: parameter name 'q' is too short, expected at least 3 characters [readability-identifier-length]
    void ObjSolvableView::set_dependencies(const ObjQueue& q) const
                                                           ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:366:9: warning: 'solvable_set_deparray' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        ::solvable_set_deparray(
        ^
/usr/include/solv/solvable.h:91:6: note: resolves to this declaration
void solvable_set_deparray(Solvable *s, Id keyname, Queue *q, Id marker);
     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:369:13: warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]
            const_cast<::Queue*>(q.raw()),
            ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:376:27: warning: 'repo_addid_dep' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        raw()->requires = ::repo_addid_dep(raw()->repo, raw()->requires, dep, /* marker= */ 0);
                          ^
/usr/include/solv/repo.h:74:15: note: resolves to this declaration
extern Offset repo_addid_dep(Repo *repo, Offset olddeps, Id id, Id marker);
              ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:379:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableViewConst::provides() const -> ObjQueue
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:381:14: warning: variable name 'q' is too short, expected at least 3 characters [readability-identifier-length]
        auto q = ObjQueue{};
             ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:382:9: warning: 'solvable_lookup_deparray' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        ::solvable_lookup_deparray(const_cast<::Solvable*>(raw()), SOLVABLE_PROVIDES, q.raw(), -1);
        ^
/usr/include/solv/solvable.h:79:5: note: resolves to this declaration
int solvable_lookup_deparray(Solvable *s, Id keyname, Queue *q, Id marker);
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:382:36: warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]
        ::solvable_lookup_deparray(const_cast<::Solvable*>(raw()), SOLVABLE_PROVIDES, q.raw(), -1);
                                   ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:386:56: warning: parameter name 'q' is too short, expected at least 3 characters [readability-identifier-length]
    void ObjSolvableView::set_provides(const ObjQueue& q) const
                                                       ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:388:9: warning: 'solvable_set_deparray' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        ::solvable_set_deparray(
        ^
/usr/include/solv/solvable.h:91:6: note: resolves to this declaration
void solvable_set_deparray(Solvable *s, Id keyname, Queue *q, Id marker);
     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:391:13: warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]
            const_cast<::Queue*>(q.raw()),
            ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:398:27: warning: 'repo_addid_dep' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        raw()->provides = ::repo_addid_dep(raw()->repo, raw()->provides, dep, /* marker= */ 0);
                          ^
/usr/include/solv/repo.h:74:15: note: resolves to this declaration
extern Offset repo_addid_dep(Repo *repo, Offset olddeps, Id id, Id marker);
              ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:404:13: warning: 'pool_rel2id' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
            ::pool_rel2id(raw()->repo->pool, raw()->name, raw()->evr, REL_EQ, /* create= */ 1)
            ^
/usr/include/solv/poolid.h:35:11: note: resolves to this declaration
extern Id pool_rel2id(Pool *pool, Id, Id, int, int);
          ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:408:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableViewConst::constraints() const -> ObjQueue
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:410:14: warning: variable name 'q' is too short, expected at least 3 characters [readability-identifier-length]
        auto q = ObjQueue{};
             ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:411:9: warning: 'solvable_lookup_deparray' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        ::solvable_lookup_deparray(const_cast<::Solvable*>(raw()), SOLVABLE_CONSTRAINS, q.raw(), -1);
        ^
/usr/include/solv/solvable.h:79:5: note: resolves to this declaration
int solvable_lookup_deparray(Solvable *s, Id keyname, Queue *q, Id marker);
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:411:36: warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]
        ::solvable_lookup_deparray(const_cast<::Solvable*>(raw()), SOLVABLE_CONSTRAINS, q.raw(), -1);
                                   ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:415:59: warning: parameter name 'q' is too short, expected at least 3 characters [readability-identifier-length]
    void ObjSolvableView::set_constraints(const ObjQueue& q) const
                                                          ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:420:13: warning: 'solvable_unset' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
            ::solvable_unset(raw(), SOLVABLE_CONSTRAINS);
            ^
/usr/include/solv/solvable.h:92:6: note: resolves to this declaration
void solvable_unset(Solvable *s, Id keyname);
     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:424:13: warning: 'solvable_set_deparray' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
            ::solvable_set_deparray(
            ^
/usr/include/solv/solvable.h:91:6: note: resolves to this declaration
void solvable_set_deparray(Solvable *s, Id keyname, Queue *q, Id marker);
     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:427:17: warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]
                const_cast<::Queue*>(q.raw()),
                ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:435:9: warning: 'solvable_add_idarray' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        ::solvable_add_idarray(raw(), SOLVABLE_CONSTRAINS, dep);
        ^
/usr/include/solv/solvable.h:88:6: note: resolves to this declaration
void solvable_add_idarray(Solvable *s, Id keyname, Id id);
     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:438:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableViewConst::track_features() const -> ObjQueue
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:440:14: warning: variable name 'q' is too short, expected at least 3 characters [readability-identifier-length]
        auto q = ObjQueue{};
             ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:441:9: warning: 'solvable_lookup_idarray' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        ::solvable_lookup_idarray(const_cast<::Solvable*>(raw()), SOLVABLE_TRACK_FEATURES, q.raw());
        ^
/usr/include/solv/solvable.h:78:5: note: resolves to this declaration
int solvable_lookup_idarray(Solvable *s, Id keyname, Queue *q);
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:441:35: warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]
        ::solvable_lookup_idarray(const_cast<::Solvable*>(raw()), SOLVABLE_TRACK_FEATURES, q.raw());
                                  ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:445:62: warning: parameter name 'q' is too short, expected at least 3 characters [readability-identifier-length]
    void ObjSolvableView::set_track_features(const ObjQueue& q) const
                                                             ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:450:13: warning: 'solvable_unset' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
            ::solvable_unset(raw(), SOLVABLE_TRACK_FEATURES);
            ^
/usr/include/solv/solvable.h:92:6: note: resolves to this declaration
void solvable_unset(Solvable *s, Id keyname);
     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:454:13: warning: 'solvable_set_idarray' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
            ::solvable_set_idarray(raw(), SOLVABLE_TRACK_FEATURES, const_cast<::Queue*>(q.raw()));
            ^
/usr/include/solv/solvable.h:90:6: note: resolves to this declaration
void solvable_set_idarray(Solvable *s, Id keyname, Queue *q);
     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:454:68: warning: do not use const_cast [cppcoreguidelines-pro-type-const-cast]
            ::solvable_set_idarray(raw(), SOLVABLE_TRACK_FEATURES, const_cast<::Queue*>(q.raw()));
                                                                   ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:458:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableView::add_track_feature(StringId feat) const -> StringId
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:460:9: warning: 'solvable_add_idarray' must resolve to a function declared within the '__llvm_libc' namespace [llvmlibc-callee-namespace]
        ::solvable_add_idarray(raw(), SOLVABLE_TRACK_FEATURES, feat);
        ^
/usr/include/solv/solvable.h:88:6: note: resolves to this declaration
void solvable_add_idarray(Solvable *s, Id keyname, Id id);
     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:464:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableView::add_track_feature(std::string_view feat) const -> StringId
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:469:5: warning: a trailing return type is disallowed for this function declaration [fuchsia-trailing-return]
    auto ObjSolvableViewConst::installed() const -> bool
    ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:474:1: warning: namespace 'mamba::solv' not terminated with a closing comment [google-readability-namespace-comments,llvm-namespace-comment]
}
^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:20:11: note: namespace 'mamba::solv' starts here
namespace mamba::solv
          ^
note: cannot apply fix-it because an alias checker has suggested a different fix-it; please remove one of the checkers ('google-readability-namespace-comments', 'llvm-namespace-comment') or ensure they are both configured the same
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.hpp:38:35: error: no type named 'string_view' in namespace 'std' [clang-diagnostic-error]
        auto name() const -> std::string_view;
                             ~~~~~^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.hpp:41:38: error: no type named 'string_view' in namespace 'std' [clang-diagnostic-error]
        auto version() const -> std::string_view;
                                ~~~~~^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.hpp:44:43: error: no type named 'string_view' in namespace 'std' [clang-diagnostic-error]
        auto build_string() const -> std::string_view;
                                     ~~~~~^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.hpp:45:40: error: no type named 'string_view' in namespace 'std' [clang-diagnostic-error]
        auto file_name() const -> std::string_view;
                                  ~~~~~^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.hpp:46:38: error: no type named 'string_view' in namespace 'std' [clang-diagnostic-error]
        auto license() const -> std::string_view;
                                ~~~~~^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.hpp:47:34: error: no type named 'string_view' in namespace 'std' [clang-diagnostic-error]
        auto md5() const -> std::string_view;
                            ~~~~~^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.hpp:48:37: error: no type named 'string_view' in namespace 'std' [clang-diagnostic-error]
        auto noarch() const -> std::string_view;
                               ~~~~~^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.hpp:49:37: error: no type named 'string_view' in namespace 'std' [clang-diagnostic-error]
        auto sha256() const -> std::string_view;
                               ~~~~~^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.hpp:58:34: error: no type named 'string_view' in namespace 'std' [clang-diagnostic-error]
        auto url() const -> std::string_view;
                            ~~~~~^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.hpp:65:38: error: no type named 'string_view' in namespace 'std' [clang-diagnostic-error]
        auto channel() const -> std::string_view;
                                ~~~~~^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.hpp:72:37: error: no type named 'string_view' in namespace 'std' [clang-diagnostic-error]
        auto subdir() const -> std::string_view;
                               ~~~~~^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.hpp:100:18: warning: function 'mamba::solv::ObjSolvableView::ObjSolvableView' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
        explicit ObjSolvableView(::Solvable& repo) noexcept;
                 ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.cpp:50:22: note: the definition seen here
    ObjSolvableView::ObjSolvableView(::Solvable& solvable) noexcept
                     ^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.hpp:100:18: note: differing parameters are named here: ('repo'), in definition: ('solvable')
        explicit ObjSolvableView(::Solvable& repo) noexcept;
                 ^                           ~~~~
                                             solvable
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.hpp:105:28: error: no type named 'string_view' in namespace 'std' [clang-diagnostic-error]
        void set_name(std::string_view str) const;
                      ~~~~~^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.hpp:107:31: error: no type named 'string_view' in namespace 'std' [clang-diagnostic-error]
        void set_version(std::string_view str) const;
                         ~~~~~^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.hpp:127:36: error: no type named 'string_view' in namespace 'std' [clang-diagnostic-error]
        void set_build_string(std::string_view bld) const;
                              ~~~~~^
/home/maxy/.gits/mamba/libmamba/src/solv-cpp/solvable.hpp:370:37: error: no type named 'string_view' in namespace 'std' [clang-diagnostic-error]
        auto add_track_feature(std::string_view feat) const -> StringId;
                               ~~~~~^

JohanMabille · 2023-06-13T20:37:41Z

Thanks for the fix. Would you mind running the linter locally to fix it? The libmamba_cpp_tests_win failure is unrelated to this PR.

I'm sorry, I don't have much experience with C++, mamba or github. I'm just an Arch user trying to fix a build issue. Would you mind explaining which linter to run and how to run it locally?

No worries, I should have been more explicit, sorry for that. I meant running pre-commit run --all-files, and then committing the changes, this should fix the linter in the CI.

None of the errors appear to be caused by this commit: reverting the commit and running diff on the outputs shows that the commit only causes some warnings:

You can indeed revert your last commit.

This reverts commit 71fa9d6.

maxyvisser · 2023-06-14T04:58:47Z

You can indeed revert your last commit.

I did not realize all of my changes in the fork would become a part of this pr, I reverted everything except the fix.

I meant running pre-commit run --all-files, and then committing the changes, this should fix the linter in the CI.

Thank you for the additional explanation, I believe I did everything properly this time. I ran pre-commit run --all-files, which changed the order of the includes. Running pre-commit run --all-files again returns no errors, so the linter in the CI should be happy now.

Add missing cstdint include to libmamba/src/solv-cpp/solvable.cpp

a81b949

maxyvisser force-pushed the main branch from 897c846 to a81b949 Compare June 13, 2023 15:18

Update linters.yml

71fa9d6

maxyvisser added 2 commits June 14, 2023 06:48

Revert "Update linters.yml"

8d0d8a6

This reverts commit 71fa9d6.

Fixed clang-format using pre-commit

1a26084

Merge branch 'main' into main

c0316ac

jonashaag approved these changes Jun 14, 2023

View reviewed changes

jonashaag merged commit 4aea24f into mamba-org:main Jun 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing cstdint include to libmamba/src/solv-cpp/solvable.cpp #2587

Add missing cstdint include to libmamba/src/solv-cpp/solvable.cpp #2587

maxyvisser commented Jun 13, 2023 •

edited

Loading

JohanMabille commented Jun 13, 2023

maxyvisser commented Jun 13, 2023

maxyvisser commented Jun 13, 2023

JohanMabille commented Jun 13, 2023 •

edited

Loading

maxyvisser commented Jun 14, 2023

Add missing cstdint include to libmamba/src/solv-cpp/solvable.cpp #2587

Add missing cstdint include to libmamba/src/solv-cpp/solvable.cpp #2587

Conversation

maxyvisser commented Jun 13, 2023 • edited Loading

JohanMabille commented Jun 13, 2023

maxyvisser commented Jun 13, 2023

maxyvisser commented Jun 13, 2023

JohanMabille commented Jun 13, 2023 • edited Loading

maxyvisser commented Jun 14, 2023

maxyvisser commented Jun 13, 2023 •

edited

Loading

JohanMabille commented Jun 13, 2023 •

edited

Loading