Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword uninstallable -> not installable #2590

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Reword uninstallable -> not installable #2590

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b971375
Reword uninstallable -> not installable
jonashaag Jun 13, 2023
81fbbfd
Merge branch 'main' into jonashaag-patch-1
jonashaag Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions libmamba/src/core/satisfiability_error.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,12 +864,12 @@ namespace mamba
const CompressedProblemsGraph& m_pbs;

/**
* Function to decide if a node is uninstallable.
* Function to decide if a node is not installable.
*
* For a leaf this sets the final status.
* For other nodes, a pacakge could still be uninstallable because of its children.
* For other nodes, a pacakge could still be not installable because of its children.
*/
auto node_uninstallable(node_id id) -> Status;
auto node_not_installable(node_id id) -> Status;

/**
* Get the type of a node depending on the exploration.
Expand Down Expand Up @@ -931,7 +931,7 @@ namespace mamba
return path;
}

auto TreeDFS::node_uninstallable(node_id id) -> Status
auto TreeDFS::node_not_installable(node_id id) -> Status
{
auto installables_contains = [&](auto&& lid) { return leaf_installables.contains(lid); };
const auto& conflicts = m_pbs.conflicts();
Expand Down Expand Up @@ -1146,9 +1146,9 @@ namespace mamba
// to visit children to exaplin conflicts.
// In most cases though, only leaves would have conflicts and the loop above would be
// empty in such case.
// Warning node_uninstallable has side effects and must be called unconditionally
// Warning node_not_installable has side effects and must be called unconditionally
// (first here).
status = !node_uninstallable(id) && status;
status = !node_not_installable(id) && status;

m_node_visited[id] = status;
return { out, status };
Expand Down Expand Up @@ -1306,7 +1306,7 @@ namespace mamba
}
else
{
write(" is uninstallable because it requires");
write(" is not installable because it requires");
}
}
else if (tn.type_from == TreeNode::Type::split)
Expand Down Expand Up @@ -1337,7 +1337,7 @@ namespace mamba
{
if (tn.depth() == 1)
{
write(" is uninstallable because there are no viable options");
write(" is not installable because there are no viable options");
}
else
{
Expand Down Expand Up @@ -1379,7 +1379,7 @@ namespace mamba
// Assuming this is always a conflict.
if (tn.depth() == 1)
{
write(" is uninstallable because it");
write(" is not installable because it");
}
else if (tn.type_from != TreeNode::Type::split)
{
Expand Down