Add Version::starts_with and Version::compatible_with #2645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| auto starts_with_three_way(const T&, const AlwaysEqual&) -> strong_ordering | ||
| { | ||
| return strong_ordering::equal; | ||
| } |
There was a problem hiding this comment.
There is an ambiguity if someone calls starts_with_three_way(AlwaysEqual(), AlwaysEqual()); I guess this combination does not make sense, but it might be worth precising it in a comment to avoid the future definition of a useless overload.
There was a problem hiding this comment.
How about adding
[[maybe_unused]] auto starts_with_three_way(const AlwaysEqual&, const AlwaysEqual&) -> strong_ordering {
static_assert(false, "This comparison should not happen with the current implementation.");
}There was a problem hiding this comment.
It doesn't work since this is not a template, I made a regular assert.
JohanMabille
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More
spec::Versioncomparison functions needed to implementVersionSpec.It also removes one level of indentation in
test_version.cpp, sorry for the big diff.