test: Comparability and hashability of PackageInfo and MatchSpec
#3369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hind-M
added
the
release::enhancements
jjerphan
force-pushed
the
test/hashability-comparability
branch
from
2ab8714
to
89360de
Compare
Hind-M
reviewed
Jul 30, 2024
| @@ -565,7 +565,7 @@ struct std::hash<mamba::util::flat_set<Key, Compare, Allocator>> | |||
| { | |||
| auto operator()(const mamba::util::flat_set<Key, Compare, Allocator>& set) const -> std::size_t | |||
| { | |||
| return mamba::util::hash_vals(set); | |||
| return mamba::util::hash_range(set); | |||
There was a problem hiding this comment.
hash_vals hashes set as a value rather than its' internal elements (I thought it would).
hash_range considers set a range and hashes all of its elements.
There was a problem hiding this comment.
I'm actually wondering about the use cases of using hash_vals, and btw I just realized there are no tests for hash_vals. Would you mind adding them please? (in this PR or another one, as you prefer).
There was a problem hiding this comment.
hash_vals is used to combine the hashes of individual scalar values. I can open a PR after this one to test its behavior.
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
force-pushed
the
test/hashability-comparability
branch
from
89360de
to
2758eca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #3363.
This adds just some simply test for
PackageInfoandMatchSpecfor now.