Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Support for PEP 440 "Compatible Releases" (operator ~= for MatchSpec) #3483

Merged
merged 5 commits into from
Sep 30, 2024
Merged

fix: Support for PEP 440 "Compatible Releases" (operator ~= for MatchSpec) #3483

merged 5 commits into from
Sep 30, 2024

Conversation

jjerphan
Copy link
Member

@jjerphan jjerphan commented Sep 30, 2024 •
edited
Loading

Fix #3472.

@jjerphan jjerphan changed the title fix: Support of ~= for MatchSpec` fix: Support of ~= for MatchSpec Sep 30, 2024
@jjerphan jjerphan added the release::bug_fixes For PRs fixing bugs label Sep 30, 2024
@jjerphan
test: Add a non-regression test
5040b1e 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan force-pushed the fix/equivalent-version-operator branch from 08c4b0b to 5040b1e Compare September 30, 2024 08:27
@jjerphan jjerphan changed the title fix: Support of ~= for MatchSpec fix: Support for PEP 440 "Compatible Releases" (operator ~= for MatchSpec) Sep 30, 2024
@jjerphan jjerphan marked this pull request as ready for review September 30, 2024 11:12
@jjerphan
Handle PEP 440 "Compatible release"
d07b761 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan
Add another non-regression test for mamba-org#3453
940dce1 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan force-pushed the fix/equivalent-version-operator branch from 938c17c to 940dce1 Compare September 30, 2024 11:17
JohanMabille
JohanMabille requested changes Sep 30, 2024
View reviewed changes
libmamba/src/specs/match_spec.cpp Outdated Show resolved Hide resolved
libmamba/src/specs/match_spec.cpp Outdated Show resolved Hide resolved
libmamba/tests/src/specs/test_match_spec.cpp Show resolved Hide resolved
@jjerphan @JohanMabille
Remove debug statements
a5e66a2 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>

Co-authored-by: Johan Mabille <johan.mabille@gmail.com>
@jjerphan
test: Install compatible release
7056766 
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@JohanMabille
Copy link
Member

JohanMabille commented Sep 30, 2024 •
edited
Loading

The CI failure is unrelated, the job should be restarted when the workflow is finished.

@jjerphan jjerphan merged commit 0b824fe into mamba-org:main Sep 30, 2024
32 checks passed
@jjerphan jjerphan deleted the fix/equivalent-version-operator branch September 30, 2024 14:41
@jjerphan jjerphan mentioned this pull request Dec 2, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanMabille JohanMabille JohanMabille approved these changes

@SylvainCorlay SylvainCorlay SylvainCorlay approved these changes

Assignees
No one assigned
Labels
release::bug_fixes For PRs fixing bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Micromamba v2.0 unable to parse environment.yml
3 participants
@jjerphan @JohanMabille @SylvainCorlay