fix: Skip misformatted configuration files #3580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjerphan
reviewed
Nov 9, 2024
There was a problem hiding this comment.
Thank you, @ChaonengQuan.
I can reproduce the error on both micromamba 1.5 and 2.0.
jjerphan
changed the title
jjerphan
changed the title
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
|
Thank you Julien, working on unit tests |
|
unit tests added, please take a look when you are available @jjerphan |
3 tasks
JohanMabille
approved these changes
Nov 12, 2024
jjerphan
approved these changes
Nov 12, 2024
|
@ChaonengQuan: can you open the same PR, but targeting the Edit: done with #3593. |
jjerphan
added a commit
to jjerphan/mamba
that referenced
this pull request
Nov 12, 2024
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Chaoneng Quan <chaonengquan@Chaonengs-MacBook-Pro.local>
|
Thank you for merging this PR! |
|
Here is the PR for |
|
Hi Julien, just wonder if you know when the next micromamba release will be and if this fix will be included? |
|
Hi, We need to merge #3593 and release 1.5.11 then. Failures on 1.x need to be understood and fixed. Feel free to work on this — we highly welcome external contributions. |
jjerphan
added a commit
to jjerphan/mamba
that referenced
this pull request
Nov 18, 2024
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Chaoneng Quan <chaonengquan@Chaonengs-MacBook-Pro.local>
jjerphan
added a commit
to jjerphan/mamba
that referenced
this pull request
Nov 18, 2024
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Chaoneng Quan <chaonengquan@Chaonengs-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3574