fix: Export 'channels' as part of environments' export
#3587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathbunnyru
commented
Nov 8, 2024
| @pytest.mark.parametrize("channel_subdir_flag", [None, "--channel-subdir"]) | ||
| @pytest.mark.parametrize("md5_flag", [None, "--md5", "--no-md5"]) | ||
| @pytest.mark.parametrize("explicit_flag", [None, "--explicit"]) | ||
| @pytest.mark.parametrize("no_build_flag", [None, "--no-build", "--no-builds"]) | ||
| @pytest.mark.parametrize("json_flag", [None, "--json"]) | ||
| def test_env_export( | ||
| export_env, json_flag, no_build_flag, explicit_flag, md5_flag, channel_subdir_flag | ||
| channel_subdir_flag, md5_flag, explicit_flag, no_build_flag, json_flag, export_env |
There was a problem hiding this comment.
This is the order it is mentioned above, it's better to have the same order everywhere
mathbunnyru
commented
Nov 8, 2024
| else: | ||
| ret = yaml.safe_load(output) | ||
| # json is already parsed | ||
| ret = output if json_flag else yaml.safe_load(output) |
There was a problem hiding this comment.
I think this is quite easy to read as a one-line
jjerphan
changed the title
env export'channels' as part of environments' export
|
I think the CI failure is spurious and this can be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I run the following:
it will give me:
Note:
channels,dependenciesare always printed, even if empty.But if I run
exportwith--json, it will not printchannels::I think it's always good to print
channels, it makes parsing easier.Related: #3582