-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maint: Update clang-format to v19 #3600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if and only if the merge commit of this PR has its diff ignored since it bring no semantic changes.
For more information, see:
To have a consistent history and since the formatting commits were always explicit, I think we should actually just leave the files diff as is (not ignored) so that we know that a change was made regarding the format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, such diffs can actually be ignored locally by developers if they want to.
@Klaim Any objections on the format result? (We may change the options if any). |
Looks tolerable to me. 👍🏽 To be completely clear, there are things I'm not a fan of but that I can totally live with:
Also I don't know the limitations of clang-format regarding these minor points, maybe it's just not possible to have the exact style I prefer. Probably not worth our time if everybody can live with this style. So I think we're good to go. 👍🏽 |
I let anyone of you merge this PR. |
Possible options (I didn't change any): https://clang.llvm.org/docs/ClangFormatStyleOptions.html