-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: List PyPI packages in environment export #3623
Merged
jjerphan
merged 4 commits into
mamba-org:main
from
jjerphan:feat/env-export-pypi-packages
Nov 21, 2024
Merged
feat: List PyPI packages in environment export #3623
jjerphan
merged 4 commits into
mamba-org:main
from
jjerphan:feat/env-export-pypi-packages
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjerphan
force-pushed
the
feat/env-export-pypi-packages
branch
from
November 20, 2024 15:42
9f29377
to
eeb7f75
Compare
jjerphan
added
the
release::enhancements
For enhancements PRs or implementing features
label
Nov 20, 2024
jjerphan
force-pushed
the
feat/env-export-pypi-packages
branch
2 times, most recently
from
November 20, 2024 18:17
89f7d31
to
b51f3b0
Compare
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
force-pushed
the
feat/env-export-pypi-packages
branch
from
November 20, 2024 18:38
b51f3b0
to
d88ee58
Compare
jjerphan
commented
Nov 20, 2024
mathbunnyru
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM, but left a few comments
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Johan Mabille <johan.mabille@gmail.com> Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
jjerphan
force-pushed
the
feat/env-export-pypi-packages
branch
from
November 21, 2024 08:56
9612088
to
8658bd5
Compare
mathbunnyru
reviewed
Nov 21, 2024
mathbunnyru
approved these changes
Nov 21, 2024
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
mathbunnyru
approved these changes
Nov 21, 2024
JohanMabille
approved these changes
Nov 21, 2024
thank you so much for merging this PR! This was a sticking point in my adoption of micromamba, and now is resolved (for my use case). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2008.
FYI, conda does not export wheels in the explicit environment specification, so I do not think
mamba
should as well.