Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: List PyPI packages in environment export #3623

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

jjerphan
Copy link
Member

@jjerphan jjerphan commented Nov 20, 2024

Fix #2008.

FYI, conda does not export wheels in the explicit environment specification, so I do not think mamba should as well.

@jjerphan jjerphan force-pushed the feat/env-export-pypi-packages branch from 9f29377 to eeb7f75 Compare November 20, 2024 15:42
@jjerphan jjerphan added the release::enhancements For enhancements PRs or implementing features label Nov 20, 2024
@jjerphan jjerphan force-pushed the feat/env-export-pypi-packages branch 2 times, most recently from 89f7d31 to b51f3b0 Compare November 20, 2024 18:17
@jjerphan jjerphan marked this pull request as ready for review November 20, 2024 18:20
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan force-pushed the feat/env-export-pypi-packages branch from b51f3b0 to d88ee58 Compare November 20, 2024 18:38
Copy link
Contributor

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM, but left a few comments

micromamba/tests/test_env.py Outdated Show resolved Hide resolved
micromamba/src/env.cpp Outdated Show resolved Hide resolved
micromamba/tests/test_env.py Outdated Show resolved Hide resolved
micromamba/tests/test_env.py Outdated Show resolved Hide resolved
micromamba/tests/test_env.py Outdated Show resolved Hide resolved
micromamba/tests/test_env.py Outdated Show resolved Hide resolved
micromamba/tests/test_env.py Outdated Show resolved Hide resolved
micromamba/src/env.cpp Outdated Show resolved Hide resolved
micromamba/src/env.cpp Show resolved Hide resolved
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>

Co-authored-by: Johan Mabille <johan.mabille@gmail.com>
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
@jjerphan jjerphan force-pushed the feat/env-export-pypi-packages branch from 9612088 to 8658bd5 Compare November 21, 2024 08:56
micromamba/src/env.cpp Outdated Show resolved Hide resolved
micromamba/tests/test_env.py Outdated Show resolved Hide resolved
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
@jjerphan jjerphan merged commit 7b0a957 into mamba-org:main Nov 21, 2024
32 checks passed
@jjerphan jjerphan deleted the feat/env-export-pypi-packages branch November 21, 2024 10:27
@zacharyburnett
Copy link

thank you so much for merging this PR! This was a sticking point in my adoption of micromamba, and now is resolved (for my use case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release::enhancements For enhancements PRs or implementing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[micromamba] micromamba env export does not show packages installed with pip
4 participants