Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use __conda_activate reactivate instead of __conda_reactivate #3702

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

hmaarrfk
Copy link
Contributor

The work in #3643 was deleted

this is really hurting users at conda-forge (myself included) conda-forge/miniforge#700 (comment)

The work in mamba-org#3643 was deleted

this is really hurting users at conda-forge (myself included)
conda-forge/miniforge#700 (comment)
@jjerphan jjerphan changed the title use __conda_activate reactivate instead of __conda_reactivate fix: Use __conda_activate reactivate instead of __conda_reactivate Dec 19, 2024
Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @hmaarrfk.

Let us release 1.5.12, then.

@jjerphan jjerphan merged commit ce1d936 into mamba-org:1.x Dec 19, 2024
17 checks passed
hmaarrfk added a commit to hmaarrfk/mamba-feedstock that referenced this pull request Dec 29, 2024
Backport of mamba-org/mamba#3702

Honestly, I've been having alot of trouble with the latest conda version

- Conda hanging: conda-forge/conda-feedstock#250
- Can't release conda build 24.11.2 -- conda-forge/miniforge#701
- I think we should just release this small backport in an attempt to
  help: conda-forge/miniforge#700
jjerphan added a commit to jjerphan/mamba that referenced this pull request Jan 2, 2025
@wolfv
Copy link
Member

wolfv commented Jan 6, 2025

Is __conda_activate defined for micromamba?

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 6, 2025

i'm not sure.

(this is the one line bug that keeps on giving....)

@wolfv
Copy link
Member

wolfv commented Jan 6, 2025

For context, some users reported infinite hanging with micromamba.https://conda.discourse.group/t/staged-recipes-linter-hangs/930

@wolfv
Copy link
Member

wolfv commented Jan 6, 2025

Should we just delete the micromamba release?

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 6, 2025

There was a large period of time (nov - Jan 3) where I had lost confidence in conda/mamba because various updates from both kept causing different lockups.

On Friday, I pushed conda-forge/conda-feedstock#251 which fixed a bug in a conda warning, so I'm wondering if that might help current users?

I don't know anything about micromamba (never tried it)

@jjerphan
Copy link
Member

jjerphan commented Jan 6, 2025

For context, some users reported infinite hanging with micromamba.https://conda.discourse.group/t/staged-recipes-linter-hangs/930

The error is resolved and was due to an out-of-date version of staged-recipe apparently.

In overall, the activation scripts seem really to be a fragile setup. I am neither confident nor satisfied about it unfortunately…

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jan 6, 2025

I'm glad we all get to live to fight an other day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants