Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Shared library support #112

Merged
merged 14 commits into from
Jul 5, 2022
Merged

Shared library support #112

merged 14 commits into from
Jul 5, 2022

Conversation

Klaim
Copy link
Member

@Klaim Klaim commented Jul 5, 2022

If I did it right:

  • CI should build and test both static and shared versions of libpowerloader (might be broken right now, will need to check the cI);
  • Use POWERLOADER_API in libpowerloader headers to mark functions (and functions in classes) that needs to be exported symbols;
  • Makes shared library build the default if BUILD_SHARED_LIBS is not specified;

Copy link
Member

@JohanMabille JohanMabille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the only missing part is binary versionning, but that might be added later. See here and here fo an example of how we set it in xeus.

@Klaim
Copy link
Member Author

Klaim commented Jul 5, 2022

Ah yes, that would be the focus of a separate PR indeed.

@wolfv wolfv merged commit 5178054 into mamba-org:main Jul 5, 2022
@Klaim Klaim mentioned this pull request Jul 6, 2022
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants