Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin h2 #500

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Unpin h2 #500

merged 1 commit into from
Mar 15, 2022

Conversation

janjagusch
Copy link
Collaborator

@janjagusch janjagusch commented Mar 11, 2022

Closes #493

I ran the test suite locally and couldn't encounter any issues with h2>=4.

@janjagusch
Copy link
Collaborator Author

@wolfv I'm getting similar CI errors as in #495, which I don't think are related to my changes. Do you have idea what might be going on here?

@wolfv wolfv closed this Mar 14, 2022
@wolfv wolfv reopened this Mar 14, 2022
@wolfv
Copy link
Member

wolfv commented Mar 14, 2022

I am re-running CI against master, let's see what happens!

@wolfv
Copy link
Member

wolfv commented Mar 14, 2022

Hm, unfortuntaely I do not see that same test failure on master ( FAILED plugins/quetz_harvester/tests/test_main.py::test_harvest_endpoint_and_job)

Not sure at all if it's related or not.

@janjagusch
Copy link
Collaborator Author

Hm, unfortuntaely I do not see that same test failure on master ( FAILED plugins/quetz_harvester/tests/test_main.py::test_harvest_endpoint_and_job)

Not sure at all if it's related or not.

Thanks for re-running against master. I will take a closer look at the error again.

@wolfv
Copy link
Member

wolfv commented Mar 14, 2022

I also triggered master again (https://github.com/mamba-org/quetz/actions/runs/1970213557) and it didn't have this error.

This may also be some unlucky combination of circumstances...

Should we cut a release first, with the current pinnings?

@janjagusch
Copy link
Collaborator Author

Should we cut a release first, with the current innings?

Yes, that would be great! Thank you.

@wolfv
Copy link
Member

wolfv commented Mar 15, 2022

Checking this PR again against the main branch.

@wolfv wolfv merged commit 0c91da2 into mamba-org:main Mar 15, 2022
@wolfv
Copy link
Member

wolfv commented Mar 15, 2022

for some reason CI didn't trigger and I thought it was green ... when it wasn't. Anyways, now I am forced to look into this error :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make compatible with h2>=4
2 participants