Add endpoints for health checks #622
Conversation
This reverts commit 5f08de5.
There was a problem hiding this comment.
Thanks for implementing @janjagusch! I'd rename the endpoints to be consistent with the Kubernetes API health endpoints, i.e.
/health/ready->/readyz/health/live->/livez
@borchero, have you ever seen this convention anywhere outside the k8s API? Most articles about health check endpoints suggest a naming scheme similar to the one I implemented here (e.g. here). I must say I prefer the current naming scheme. :) |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
==========================================
- Coverage 82.22% 81.36% -0.86%
==========================================
Files 78 78
Lines 6120 6124 +4
==========================================
- Hits 5032 4983 -49
- Misses 1088 1141 +53
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@janjagusch I've seen it a bunch of times (see https://stackoverflow.com/questions/43380939/where-does-the-convention-of-using-healthz-for-application-health-checks-come-f which would also imply it's used in quite a few places) but I don't have a strong opinion. I've also seen the |
|
Both can be created and the discussion is over! |
Closes #620.