Use PEP-593 Annotated for options and arguments in CLI commands #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
rominf
force-pushed
the
rominf-cli-annotated
branch
from
b723504 to
3938b6c
Compare
1 task
`typer` 0.9.0 introduced the support for PEP-593 `Annotated` for specifying options and argument and it is recommended to use it: https://typer.tiangolo.com/release-notes/#090
rominf
force-pushed
the
rominf-cli-annotated
branch
from
3938b6c to
14700a6
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
==========================================
+ Coverage 83.21% 83.26% +0.05%
==========================================
Files 78 78
Lines 6184 6186 +2
==========================================
+ Hits 5146 5151 +5
+ Misses 1038 1035 -3
☔ View full report in Codecov by Sentry. |
|
@janjagusch I can't add label |
janjagusch
approved these changes
Jun 20, 2023
ivergara
pushed a commit
to ivergara/quetz
that referenced
this pull request
Jun 21, 2023
…a-org#644) `typer` 0.9.0 introduced the support for PEP-593 `Annotated` for specifying options and argument and it is recommended to use it: https://typer.tiangolo.com/release-notes/#090
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typer0.9.0 introduced the support for PEP-593Annotatedforspecifying options and argument and it is now recommended to use it:
https://typer.tiangolo.com/release-notes/#090