Fix event loop errors #650
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
==========================================
+ Coverage 83.14% 83.26% +0.11%
==========================================
Files 78 78
Lines 6153 6184 +31
==========================================
+ Hits 5116 5149 +33
+ Misses 1037 1035 -2
☔ View full report in Codecov by Sentry. |
quetz/pkgstores.py
Outdated
| self.fs = s3fs.S3FileSystem( | ||
| key=key, secret=secret, asynchronous=True, client_kwargs=client_kwargs | ||
| key=key, | ||
| secret=secret, | ||
| asynchronous=True, | ||
| client_kwargs=client_kwargs, | ||
| ) | ||
| self.fs._loop = get_loop() |
There was a problem hiding this comment.
@martindurant, I hope you don't mind that I'm looping you in here. This is a follow-up from our conversation in fsspec/filesystem_spec#1290. You suggested to explicitly pass the loop argument to the file system constructor. However, this doesn't seem possible, since whenever asynchronous=True then self._loop=None (see here).
The only solution I could come up with is to set the self._loop attribute after the object has been instantiated. Is this a bug in fsspec or am I doing something wrong?
Thanks a lot for your help!
There was a problem hiding this comment.
Perhaps the easiest is to follow the pattern in a test: https://github.com/fsspec/s3fs/blob/main/s3fs/tests/test_s3fs.py#L2000
I am sure this is also documented, but where to look between s3fs's and fsspec's docs isn't always clear. Help always appreciated...
There was a problem hiding this comment.
but again, the best thing you can do is actually create the filesystem object within a coroutine, in which case the asynchronous and loop kwargs should not be necessary (but you cannot call any sync-API methods)
* Add pytest-asyncio as dependency. * Explicitly pass loop. * Pass loop outside of constructor. * Debug. * Revert "Debug." This reverts commit 3fba70b. * Implement s3 pkgstore async correctly. * Implement azure pkgstore async correctly. * Implement gcs pkgstore async correctly.
No description provided.