chore: Add more tracing #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjerphan
force-pushed
the
add-more-tracing
branch
from
941ee7c
to
2107341
Compare
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
force-pushed
the
add-more-tracing
branch
from
2107341
to
ae6c794
Compare
baszalmstra
requested changes
Jul 17, 2024
There was a problem hiding this comment.
Thanks for this!
You changed a lot of places to display ids instead of the rhings the ids represent. I can understand that this makes debugging some things easier but it also makes following the general flow of the algorithm much harder. Could we maybe show both? The id and the representation of the id?
You inplemented Display in a few places in a way that almost exactly mimics the (derived) Debug trait. Maybe you can use rhat instead?
I think the levels are sometimes quite high. Perhaps consider downgrading some info and debug logs to trace level instead?
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Bas Zalmstra <bas@prefix.dev>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Bas Zalmstra <bas@prefix.dev>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Bas Zalmstra <bas@prefix.dev>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Bas Zalmstra <bas@prefix.dev>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Bas Zalmstra <bas@prefix.dev>
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Bas Zalmstra <bas@prefix.dev>
jjerphan
force-pushed
the
add-more-tracing
branch
from
c81827e
to
fdc4765
Compare
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
baszalmstra
reviewed
Jul 18, 2024
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Bas Zalmstra <bas@prefix.dev>
jjerphan
force-pushed
the
add-more-tracing
branch
from
4c692ee
to
a37a65a
Compare
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
baszalmstra
approved these changes
Jul 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.