-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Propagate errors from micromamba-shell #241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the version in package.json?
Woah, thanks @pavelzw for the instant response! Do you know offhand if it would be safe to assume that I'm wondering now if |
i think this is a fair assumption. micromamba-shell is only supported on unix anyway exec sounds fair, let's do that |
Ok, I need to do a few quick tests first since I'm wondering what's going on in terms of shell processing and if we would lose that with |
Before, when the micromamba-shell command failed, the exit command would not be propagated, leading to silent failures. Now execution is passed to micromamba-shell so that the parent shell is replaced, and the exit code is that of the micromamba-shell process.
Ok @pavelzw, I checked and |
If the micromamba-shell command fails, the exit command is not propagated, leading to silent failures.
Consider if possible switching to bash for
-o pipefail
support.