Fixed regex for matching versions #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klaim
approved these changes
Dec 10, 2024
jjerphan
reviewed
Dec 10, 2024
src/options.ts
Outdated
| @@ -295,7 +295,7 @@ export const getOptions = () => { | |||
| ), | |||
| micromambaVersion: parseOrUndefined( | |||
| 'micromamba-version', | |||
| z.union([z.literal('latest'), z.string().regex(/^\d+\.\d+\.\d+-\d+$/)]), | |||
| z.union([z.literal('latest'), z.string().regex(/^\d+\.\d+\.\d+(?:\.(?:rc|alpha|beta)\d+)?-\d+$/)]), | |||
There was a problem hiding this comment.
To match PEP440 version numbers of release candidates, alphas, and betas (for instance 2.0.0rc0):
Suggested change
| z.union([z.literal('latest'), z.string().regex(/^\d+\.\d+\.\d+(?:\.(?:rc|alpha|beta)\d+)?-\d+$/)]), | |
| z.union([z.literal('latest'), z.string().regex(/^\d+\.\d+\.\d+(?:\.?(?:rc|alpha|beta)\d+)?-\d+$/)]), |
There was a problem hiding this comment.
This does not work. I think it's rather ^\d+\.\d+\.\d+(?:\.?(?:rc|alpha|beta)\d*)?-\d+$ (yes, I let you find the single character I had to change :D)
My bad, I entered wrong matches.
There was a problem hiding this comment.
Let's go. :)
Suggested change
| z.union([z.literal('latest'), z.string().regex(/^\d+\.\d+\.\d+(?:\.(?:rc|alpha|beta)\d+)?-\d+$/)]), | |
| z.union([z.literal('latest'), z.string().regex(/^\d+\.\d+\.\d+(?:\.?(?:rc|alpha|beta)\d*)?-\d+$/)]), |
Hind-M
reviewed
Dec 10, 2024
src/options.ts
Outdated
| @@ -295,7 +295,7 @@ export const getOptions = () => { | |||
| ), | |||
| micromambaVersion: parseOrUndefined( | |||
| 'micromamba-version', | |||
| z.union([z.literal('latest'), z.string().regex(/^\d+\.\d+\.\d+-\d+$/)]), | |||
| z.union([z.literal('latest'), z.string().regex(/^\d+\.\d+\.\d+(?:\.(?:rc|alpha|beta)\d+)?-\d+$/)]), | |||
There was a problem hiding this comment.
Should we add dev as well since it was added here?
pavelzw
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.