Use new EnvironmentVariableCollection API #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on all shells and OS microsoft/vscode#179476 Introduced a new API for EnvironmentVariableCollection that properly handles shell integrations, including login always shells on macOS Update `@types/vscode` and `@vscode/test-electron` to the latest versions to allow use of the new API Update `activateTerminal` to use new API: - use `applyAtShellIntegration: true` only for `PATH` variable because `info.vars` contains entrire environment, including read only variables like `PWD`, `SHLVL` and `_` which will error out. TODO: these read only vars and maybe some others should be cleaned up before replacing them everywhere
…void conficts upon propagation to new shell and subprocesses
Pull Request Test Coverage Report for Build 10086318472Details
💛 - Coveralls |
…API and sync engines to it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new EnvironmentVariableCollection API introduced in microsoft/vscode#179476 allows to (re)apply environment variables at the shell integration stage. This is crucial for macOS which uses login shell as default and overrides or prepends set PATH on startup, leading to micromamba paths being absent or push towards the end. This results in system binaries being used as default, essentially deactivating the conda environment
Update
@types/vscodeand@vscode/test-electronto the latest versions to allow use of the new APIPass in EnvironmentVariableMutatorOptions{ applyAtProcessCreation: true, applyAtShellIntegration: true } to guarantee PATH and other environment variables reapplication after default shell initializtion is complete
Add filtering of the standard shell and vscode environment variables in
parseMicromambaShellActivateResponsein order to avoid attempting to change read-only variables like PWD and SHLVL as well as causing potential side effects with process specific variables like VSCODE_ (see in code comments for more details)