Limit extension activation events #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently activation event is set to `*` which makes extension always active. This results in extension always showing `Micromamba: Open a folder or a workspace` on startup And extension will attempt to activate for every workspace even if it has no environment file consuming memory and CPU. Extension packaging with `vcse` confirms this with the following warning: ``` WARNING Using '*' activation is usually a bad idea as it impacts performance. More info: https://code.visualstudio.com/api/references/activation-events#Start-up ``` By limiting `activationEvents` to `workspaceContains:environment*.{yml,yaml}` extension will remain out of memory unless there is an environment file it can read to activate it. All the commands extension provides are still available and extension will be activate upon command execution: ``` 2024-07-24 18:43:22.918 [info] ExtensionService#_doActivateExtension corker.vscode-micromamba, startup: false, activationEvent: 'onCommand:corker.micromamba.activate.environment.by.path' ```
Pull Request Test Coverage Report for Build 10086736042Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently activation event is set to
*which makes extension always active.This results in extension always showing
Micromamba: Open a folder or a workspaceon startupAnd extension will attempt to activate for every workspace even if it has no environment file consuming memory and CPU.
Extension packaging with
vcseconfirms this with the following warning:By limiting
activationEventstoworkspaceContains:environment*.{yml,yaml}extension will remain out of memory unless there is an environment file it can read to activate it. All the commands extension provides are still available and extension will be activate upon command execution: