Skip to content

Conversation

@clawgrip
Copy link
Contributor

@clawgrip clawgrip commented Oct 9, 2024

New systems marked not working

IBM ThinkPad 600X [ArcadeHacker]
IBM ThinkPad 760XD [ArcadeHacker]
IBM ThinkPad 770Z [ArcadeHacker]

Also added RTC, MCU clock and notes.

New systems marked not working
------------------------------
IBM ThinkPad 760XD [ArcadeHacker]
@angelosa
Copy link
Member

I don't think I like the driver naming direction this is taking off.
I gave a glance at ref catalogs, everything between 200 and 799 uses an Intel CPU (jumping between ISA/MCA and then PCI), and I believe the IBM classification has more to do with form factors than anything else.

As an example: the ThinkPad 760XD maps a 82430MX PCI chipset, that's shared with ThinkPad 560, so this driver should be named thinkpadx6x.cpp by following the model number logic.

@clawgrip clawgrip changed the title Add a skeleton for IBM ThinkPad 760 series laptops Add (not working) ThinkPad 760XD and ThinkPad 770Z laptops Nov 11, 2024
@angelosa
Copy link
Member

Related to #13016 , which will most likely throw a git conflict either way.

@clawgrip clawgrip changed the title Add (not working) ThinkPad 760XD and ThinkPad 770Z laptops Add (not working) ThinkPad 600X, 760XD and 770Z laptops Jan 20, 2025
@clawgrip clawgrip changed the title Add (not working) ThinkPad 600X, 760XD and 770Z laptops Add (not working) ThinkPad 600X, 760XD, and 770Z laptops Jan 20, 2025
@cuavas
Copy link
Member

cuavas commented Sep 8, 2025

@angelosa can this be salvaged? Does this mix multiple generations/product lines that should be in separate files, or is it a single generation and the source file just needs renaming? Do you think you can make the adjustments on the PR branch? It’s really little more than a squeleton driver at this point.

@angelosa
Copy link
Member

angelosa commented Sep 8, 2025

It's not a skeleton, the driver is for PCI era ThinkPads (there are a ton, I've sent you a document in PM).
afaik they mix and match various chipsets with IBM laptop devices, with H8/3437 as keyboard CPU. Had this at some point, iirc before attaching the Super I/O and with a VGA connected:

0000

@angelosa
Copy link
Member

angelosa commented Sep 8, 2025

That to say, it's been 9 months of no comms from #13016 , so your take about what to do here.

@cuavas
Copy link
Member

cuavas commented Sep 8, 2025

That to say, it's been 9 months of no comms from #13106 , so your take about what to do here.

If you think you can salvage it, then I’d recommend you merge master into the PR branch and then do the minimum to get it to the level where you can merge it without wanting to cry.

If that isn’t possible, maybe just add squeleton drivers to hold the ROMs on master and close this PR?

@angelosa
Copy link
Member

angelosa commented Sep 8, 2025

Busy with MD plus current master emumem breakages doesn't make me eager to look at the other one for now.

@angelosa angelosa merged commit 8283606 into mamedev:master Sep 8, 2025
5 checks passed
@clawgrip clawgrip deleted the thinkpad760 branch September 8, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants