Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Roland PRO-E Arranger #13349

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

giulioz
Copy link
Contributor

@giulioz giulioz commented Feb 9, 2025

Kinda works, timers are flaky, requires external MT-32 emulation (MUNT works).
Test mode for RAM and ROM passes.

Screenshot 2025-02-09 at 22 12 55

@happppp
Copy link
Member

happppp commented Feb 10, 2025

You forgot to initialize m_baud. If the CPU manual says it's unmodified at reset, do m_baud = 0 at device_start.
Also, the new variables each need a save_item.

@giulioz
Copy link
Contributor Author

giulioz commented Feb 10, 2025

@happppp good point, fixed it now

@happppp
Copy link
Member

happppp commented Feb 10, 2025

Same thing in the driver by the way: If you want savestates to work, add a save_item to machine_start for keyscan and lcd mode.
Also, MAME drivers add m_ prefix to class variables.

@giulioz
Copy link
Contributor Author

giulioz commented Feb 10, 2025

@happppp
Should be all done, took note for my future contributions, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants