(Repost) Add a Non Working Driver For Fruit Cocktail fruitctk.cpp #14253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was managed to hook up |
angelosa
reviewed
Oct 3, 2025
src/mame/misc/fruitctk.cpp
Outdated
Comment on lines
96
to
97
|
|
||
| { } |
There was a problem hiding this comment.
Pretty sure this spacing shouldn't be there by C++ standards.
angelosa
reviewed
Oct 3, 2025
src/mame/misc/fruitctk.cpp
Outdated
Comment on lines
175
to
189
|
|
||
|
|
||
|
|
||
| PORT_START("DSW1") | ||
| PORT_DIPUNKNOWN_DIPLOC(0x01, 0x01, "SW1:1") | ||
| PORT_DIPUNKNOWN_DIPLOC(0x02, 0x02, "SW1:2") | ||
| PORT_DIPUNKNOWN_DIPLOC(0x04, 0x04, "SW1:3") | ||
| PORT_DIPUNKNOWN_DIPLOC(0x08, 0x08, "SW1:4") | ||
| PORT_DIPUNKNOWN_DIPLOC(0x10, 0x10, "SW1:5") | ||
| PORT_DIPUNKNOWN_DIPLOC(0x20, 0x20, "SW1:6") | ||
| PORT_DIPUNKNOWN_DIPLOC(0x40, 0x40, "SW1:7") | ||
| PORT_DIPUNKNOWN_DIPLOC(0x80, 0x80, "SW1:8") | ||
|
|
||
|
|
||
| PORT_START("DSW2") |
There was a problem hiding this comment.
More inconsistent spacing/tabs.
angelosa
reviewed
Oct 3, 2025
src/mame/misc/fruitctk.cpp
Outdated
| PORT_BIT( 0x40, IP_ACTIVE_HIGH, IPT_BUTTON1 ) PORT_CODE(KEYCODE_V) | ||
| PORT_BIT( 0x80, IP_ACTIVE_HIGH, IPT_BUTTON1 ) PORT_CODE(KEYCODE_B) | ||
|
|
||
| PORT_START("Inputs4") |
There was a problem hiding this comment.
Conventionally input labels are in UPPERCASE.
angelosa
reviewed
Oct 3, 2025
Comment on lines
+217
to
+226
| switch (m_selected_7seg_module & 0x07) | ||
| { | ||
| case 0: | ||
| case 1: | ||
| case 2: | ||
| case 3: | ||
| return m_inputs[m_selected_7seg_module & 0x07]->read(); | ||
| default: | ||
| return 0x00; | ||
| } |
There was a problem hiding this comment.
What's the point of this switch-case? Is bit 2 just a selection between p1 and p2 sides?
angelosa
reviewed
Oct 3, 2025
src/mame/misc/fruitctk.cpp
Outdated
Comment on lines
244
to
252
| map(0x8000, 0x87ff).ram().share("nvram"); | ||
| map(0xc000, 0xc001).w("opll", FUNC(ym2413_device::write)); | ||
| map(0x9002, 0x9003).rw("ay1", FUNC(ay8910_device::data_r), FUNC(ay8910_device::address_data_w)); | ||
| map(0xb000, 0xb001).rw("i8279", FUNC(i8279_device::read), FUNC(i8279_device::write)); | ||
| map(0xb004, 0xb004).rw(m_oki, FUNC(okim6295_device::read), FUNC(okim6295_device::write)); | ||
| map(0xb008, 0xb00a).rw("ppi1", FUNC(i8255_device::read), FUNC(i8255_device::write)); // ??? | ||
| // map(0xb00b, 0xb00b).nopw(); // ?? Write = 80 | ||
| // map(0xb00c, 0xb00c).nopw(); // Led | ||
| map(0xb00d, 0xb00f).rw("ppi2", FUNC(i8255_device::read), FUNC(i8255_device::write)); // ??? |
There was a problem hiding this comment.
Again, conventionally we add a tab space in memory map lines.
angelosa
reviewed
Oct 3, 2025
src/mame/misc/fruitctk.cpp
Outdated
|
|
||
| ROM_REGION( 0x40000, "oki", 0 ) | ||
| ROM_LOAD( "w27c02.bin", 0x00000, 0x40000, CRC(A8217121) SHA1(a35004f00632b552b587dfa12c1698abada5e300) ) // Voices Rom | ||
| ROM_END |
There was a problem hiding this comment.
i.e.:
ROM_START( romset )
[content here]
ROM_END
angelosa
reviewed
Oct 3, 2025
src/mame/misc/fruitctk.cpp
Outdated
Comment on lines
264
to
267
| config.set_default_layout(layout_marywu); | ||
|
|
||
| /* basic machine hardware */ | ||
| i8051_device &maincpu(I8051(config, "maincpu", XTAL(12'000'000))); |
There was a problem hiding this comment.
Conventionally the machine_config should have following order:
void config_state::config_name(machine_config &config)
{
[CPU declarations]
[I/O class devices]
[video]
[sound]
}Put in another way, config.set_default_layout should go before sound, in no case as first declared thing.
originally some code are pasted from orientp where contains adpcm.
was from marywu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous now closed #14252
Sorry for my mistake. instead of solving.
Dumped by my friend.
it is a 8051 roulette Board.
Currently shown error 02. Input was guessed after found ways to bypass the error.
Info and driver cpp in wip.
Layout currently not correctly. was from marywu
Some code are from marywu.cpp
Led controller are different than marywu.
If have anything to ask let me known.
Question:
which name choosen? only to prevent confusion.