Skip to content

Conversation

cam900
Copy link
Contributor

@cam900 cam900 commented Oct 15, 2025

seibuspi_base_state::video_start() contains needs-to-initialized variables, and should be called after initialization routine in each child video_start() functions. seibu/seibuspi.cpp: Add notes

seibuspi_base_state::video_start() contains needs-to-initialized variables, and should be called after initialization routine in each child video_start() functions.
seibu/seibuspi.cpp: Add notes
@cam900 cam900 changed the title seibu/seibucats.cpp, seibu/seibuspi.cpp: Fix regression since 3bc4210656939f870e68f95e1990345571383150 seibu/seibucats.cpp, seibu/seibuspi.cpp: Fix regression since commit 3bc4210656939f870e68f95e1990345571383150 Oct 15, 2025
@cuavas
Copy link
Member

cuavas commented Oct 15, 2025

Is it possible to provide the configuration some other way? For example, make palette and sprite RAM into memory_share_creator and supply sizes to the base class constructors, or have some way of supplying the setup information from the machine configuration functions.

Having stuff in the base class that depends on initialisation from the derived classes seems like an error-prone approach.

@cuavas cuavas merged commit 93c0142 into mamedev:master Oct 17, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants