add adpcm bank code. huangyeh_m68k.cpp #14517
Conversation
the code was from another driver that still in pull request. due to preliminary emulation status I had to use pc = 061C and check something at error log.
flama12333
changed the title
flama12333
changed the title
Has sound. Demote since something need to verify hw.
src/mame/skeleton/huangyeh_m68k.cpp
Outdated
| void huangyeh_m68k_state::adpcm_bank(uint8_t data) | ||
| { | ||
|
|
||
| m_oki->set_rom_bank(data & 0x01); |
There was a problem hiding this comment.
Function name for write to something is normally (function)_w, and Indentation consistency is should be correct. (in this case, it should be 1 tab, instead 2 tabs.)
There was a problem hiding this comment.
the adpcm rom has two bank. let me to check.
There was a problem hiding this comment.
I I already used the data & 0x01 after making the pull request.
will cause the issues if I edit data & 0x02
error log:
[:oki] Warning: requested bank 2 higher than actual bank count 2
[:oki] Requested to play invalid sample 4a
There was a problem hiding this comment.
You should check whatever program you're using for machine translation, because clearly you are misunderstanding what is being said.
The comment has to do with INDENTING. You should be using 1 four-space tab, not 2 tabs.
|
the adpcm pitch clock was verified. |
3 participants
the adpcm bankcode was from another driver that still in pull request. due to preliminary emulation status
I had to use pc = 061C to attract mode and check something at error log.