BFM_Cobra3 - attempt to improve non-MPEG hardware parts. #14588
+537
−304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MooglyGuy
requested changes
Nov 27, 2025
| offset &= 0x7ff; | ||
| offs_t cs_addr_8_11 = (offset * 2) & 0xf00; | ||
|
|
||
| switch(cs_addr_8_11) |
Contributor
There was a problem hiding this comment.
Please ensure consistent spacing, per https://docs.mamedev.org/contributing/cxx.html#spacing (compare to line 139).
| switch(cs_addr_8_11) | ||
| { | ||
| case 0x300: //ac0300 | ||
| if(ACCESSING_BITS_0_7) |
Contributor
There was a problem hiding this comment.
Ibid, and through the rest of the file.
src/mame/bfm/bfm_cobra3.cpp
Outdated
| switch (cs) | ||
| { | ||
| case 1://ROM, shouldn't write here? | ||
| logerror("%08x maincpu write access(1) offset %08x data %08x mem_mask %08x cs %d\n", pc, offset*4, data, mem_mask, cs); |
Contributor
There was a problem hiding this comment.
As above, and throughout the file.
Also, please use machine().describe_context(), not m_maincpu->pc().
src/mame/bfm/bfm_cobra3.cpp
Outdated
| } | ||
| break; | ||
|
|
||
| case 4: //0x00b10000 SCSI controller |
Member
Author
There was a problem hiding this comment.
This was me trying to rationalise CS access to an old school memory map for rationalisation. Not really needed, so I've removed this and other similar lines.
------------------------------ Telly Addicts (New Series) (Bellfruit) (Cobra 3) [James Wallace, blueonesarefaster] bfm_cobra3.cpp - hook up revised CD dumps and non-MPEG graphics hardware [James Wallace, blueonesarefaster]
james-wallace-ghub
force-pushed
the
cobra3_dumps
branch
from
3bc56ad to
5524834
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New systems marked not working
Telly Addicts (New Series) (Bellfruit) (Cobra 3) [James Wallace, blueonesarefaster]
bfm_cobra3.cpp - hook up revised CD dumps and non-MPEG graphics hardware [James Wallace, blueonesarefaster]