various reorganization of radica and vtech stuff #3108
Conversation
hash/megadriv.xml
Outdated
| </part> | ||
| </software> | ||
|
|
||
| <!-- the Radica titles are handled as standalone sets in MAME, left here for reference --> |
There was a problem hiding this comment.
Please don't leave commented crud - it just rots.
There was a problem hiding this comment.
it serves as an example of how you can still add them / load them with the softlist if you want, which I think is useful.
scripts/target/mame/arcade.lua
Outdated
| MAME_DIR .. "src/mame/drivers/megadrvb.cpp", | ||
| MAME_DIR .. "src/mame/includes/megadrvb.h", | ||
| MAME_DIR .. "src/mame/drivers/megadriv_arcade_clones.cpp", | ||
| MAME_DIR .. "src/mame/includes/megadriv_arcade_clones.h", |
There was a problem hiding this comment.
Please use more terse source file names.
There was a problem hiding this comment.
I think the more verbose filenames help in this case, that's why I'm using them
they're based on megadrive hardware, they're for the arcades, and not official sega hardware.
megadriv_ is because that's the standard identifier for megadrive, and arcade_clones because frankly arclone or similar just looks weird.
There was a problem hiding this comment.
I'd prefer to put them in a megadriv folder, if that's an option, but that seems to be a non-standard approach.
There was a problem hiding this comment.
I'd just name it megadriv_bootleg.cpp. Let's say for example you'd find a home version of a standalone game Megadrive bootleg, it can be placed in this driver too(instead of making megadriv_home_clones just because it doesn't have a coin slot?)
There was a problem hiding this comment.
Much like system/software shortnames, we have to work with source file names. Making them excessively long makes them annoying to type, increases the width of columns in multi-column listings, reduces the number of columns that can be shown in potential completions on the command line, etc. There's value in being terse.
src/mame/audio/radicasi.cpp
Outdated
|
|
||
| WRITE8_MEMBER(radica6502_sound_device::radicasi_sound_unk_w) | ||
| { | ||
| logerror("%s: radicasi_sound_unk_w %02x\n", machine().describe_context().c_str(), data); |
There was a problem hiding this comment.
Please don't use unnecessary .c_str() calls - logerror can handle std::string just fine.
src/mame/audio/radicasi.h
Outdated
| @@ -0,0 +1,61 @@ | |||
| #ifndef MAME_AUDIO_RADICASI_H | |||
There was a problem hiding this comment.
This file is missing copyright/licence annotation comments.
| int m_protcount; | ||
| }; | ||
|
|
||
| #endif // MAME_INCLUDES_MEGADRIV_ARCADE_CLONES_H |
There was a problem hiding this comment.
Missing end-of-line at end of file.
src/mame/includes/megadriv_radica.h
Outdated
| required_region_ptr<uint16_t> m_rom; | ||
| }; | ||
|
|
||
| #endif // MAME_INCLUDES_MEGADRIV_RADICA_H No newline at end of file |
src/mame/machine/radicasi_gpio.h
Outdated
|
|
||
| DECLARE_DEVICE_TYPE(RADICA6502_GPIO, radica6502_gpio_device) | ||
|
|
||
| #endif // MAME_AUDIO_RADICASI_GPIO_H No newline at end of file |
added Radica Sensible Soccer [Sean Riddle]
ghost
deleted the
this is a re-synced version of the previous PR as changes in master meant that no longer compiled. (these are all TV game and similar Epoxy blob system related changes)
--
split radica6502 driver up into multiple files
split vtech geniusiq driver up into multiple files
added driver for VTech Reader Laptop E
correct parent/clone status of a number of sets in vii.cpp
elevated the Radica TV Games that were in the Megadrive softlist to be proper MAME sets
and..
new machine marked as NOT WORKING : Radica Golden Tee Golf Home Edition [Sean Riddle]