Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should reply with ERROR and not QUIT to a QUIT #62

Open
progval opened this issue Dec 20, 2015 · 3 comments
Open

Should reply with ERROR and not QUIT to a QUIT #62

progval opened this issue Dec 20, 2015 · 3 comments
Assignees

Comments

@progval
Copy link
Contributor

progval commented Dec 20, 2015

Log:

1: connects to server.
1 -> S: NICK foo
1 -> S: USER username * * :Realname
S -> 1: :MyLittleServer NOTICE foo :*** Looking up your hostname...
S -> 1: :MyLittleServer NOTICE foo :*** Checking Ident
S -> 1: :MyLittleServer NOTICE foo :*** Found your hostname: localhost
S -> 1: :MyLittleServer NOTICE foo :*** No Ident response
S -> 1: :MyLittleServer 001 foo :Welcome to the MyLittleNetwork IRC Network, foo!~username@localhost
1 -> S: PING foo
S -> 1: :MyLittleServer 002 foo :Your host is MyLittleServer, running version mammon-0
S -> 1: :MyLittleServer 003 foo :This server was started at Sun Dec 20 2015 at 23:49:58 CET
S -> 1: :MyLittleServer 004 foo MyLittleServer mammon-0 Zwoi
S -> 1: :MyLittleServer 005 foo REGCOMMANDS=CREATE,VERIFY MONITOR=20 SAFELIST CASEMAPPING=rfc3454 CHANTYPES=# NETWORK=MyLittleNetwork USERLEN= NICKLEN= CHANNELLEN= REGCALLBACKS= TOPICLEN= LINELEN= REGCREDTYPES=passphrase METADATA :are supported by this server
S -> 1: :MyLittleServer 375 foo :- MyLittleServer Message of the Day -
S -> 1: :MyLittleServer 372 foo :- Hi
S -> 1: :MyLittleServer 376 foo :End of /MOTD command.
S -> 1: :MyLittleServer PONG foo
1 -> S: QUIT
S -> 1: :foo!~username@localhost QUIT :Quit:

Expected behavior: “The server acknowledges […] by sending an ERROR message to the client” instead of QUIT.
section 3.1.7 of RFC 2812

@DanielOaks
Copy link
Member

Servers seem a little fragmented on what to do here. We'll probably copy Charyb and dump a QUIT (like we already do) then an ERROR, as this will also play with the kline/dline stuff I'm working on.

@progval
Copy link
Contributor Author

progval commented Dec 21, 2015

Looks good to me

@DanielOaks
Copy link
Member

Alrighty, I'll merge it in with the kline stuff, and close this issue once it's in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants