Unify usage of Icons #2814
Unify usage of Icons #2814
Conversation
dala318
force-pushed
the
icons
branch
2 times, most recently
from
71917d9 to
b563f2e
Compare
|
For now don't want to spend a whole afternoon to copy-pasting icon usage in all services, specially if it's not something you want implemented or in a different way, but fixed the first in alphabetical order as an example for the rest. |
|
I generally do like this. It does not have a very high priority, but having an ENUM for the waste types is quite nice Note to also update https://github.com/mampfes/hacs_waste_collection_schedule/blob/master/doc/contributing_source.md I thought about implementing this/or some fallback in the Collection class. The advantage would be that ICS sources would profit from this, as they currently only get the default ICON and you have to set your own if you want to change it. But I don't think this is a good fit as names vary drastically between sources (languages/bin colors/ waste types / bin size ....). I also thought about implementing a default ICON_MAP to import into sources, but it has basically the same problems/limitations as above |
- Drop inheritance in favor of EXTRA_INFO, thanks @5ila5 - Align icons on mampfes#2814 - Add more instances: Châteauroux, Saint Quentin en Yvelines, Saumur, Versailles
…ances (#2824) * Add a generic source for publidata based French areas + specific instances Support for schedules provided by [Publidata](https://www.publidata.io/fr/). They operate the schedules of at least the following communities: - GPSEO - Orléans Métropole - Tours métropole A specific source is provided for GPSEO, Orléans Métropole and Tours Métropole. The reason going for both the generic and specic approaches is to both improve discoverability of the integration for inhabitants from the three mentioned areas, and still leave the possibility to some more adventurous users from other, covered by publidata places, to benefit from it. * fix remaining copy-pastingg traces * Fix & improvements after review - Drop inheritance in favor of EXTRA_INFO, thanks @5ila5 - Align icons on #2814 - Add more instances: Châteauroux, Saint Quentin en Yvelines, Saumur, Versailles * fix variable name * Update publidata_fr.md after previous changes * reformatting + ./update_docu_links.py --------- Co-authored-by: Vincent Desprez <vincent.desprez@qonto.com> Co-authored-by: 5ila5 <5ila5@users.noreply.github.com>
|
Yeah, my idea with this was not to automate icon assignment but only to select one for every basic type and then in every service promote selecting from those when the actual translation is done. |
dala318
force-pushed
the
icons
branch
2 times, most recently
from
7b0b96d to
68f4a91
Compare
Updated template |
|
The |
| # Build a git-exclude and git-include strings | ||
| grep_exclude="" | ||
| grep_include="" | ||
| for excluded in "${whitelist[@]}" |
There was a problem hiding this comment.
This loop (and above list of excluded files) could be replaced by adding a specific string or in each source file that shall be excluded by check and then replace the loop with the following:
for excluded in $(git grep --name "CUSTOM_ICON_WHITELIST = True" -- $checkpath); do
base=$(basename $excluded)
grep_exclude="${grep_exclude} :(exclude)*${base}"
grep_include="${grep_include} ${checkpath}${base}"
done
Proposal of implementation for #2813