Adding support for Lipizzanerheimat App, Austria #3209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5ila5
reviewed
Dec 18, 2024
...components/waste_collection_schedule/waste_collection_schedule/source/lipizzanerheimat_at.py
Show resolved
Hide resolved
5ila5
reviewed
Dec 18, 2024
...components/waste_collection_schedule/waste_collection_schedule/source/lipizzanerheimat_at.py
Outdated
Show resolved
Hide resolved
5ila5
reviewed
Dec 18, 2024
Comment on lines
307
to
309
| raise SourceArgumentNotFound( | ||
| [], "No data found for the provided arguments.") | ||
|
|
5ila5
reviewed
Dec 21, 2024
Comment on lines
+268
to
+270
| if (community_id == None): | ||
| raise SourceArgumentNotFound( | ||
| [], "Town/Street combination not found.") |
There was a problem hiding this comment.
This exception does not work like this. (see above)
You could raise the SourceArgumentNotFoundWithSuggestions exception in the fetch_communities function to provide feedback which towns would be valid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Lipizzanerheimat, Austria
Format documentation
reformatting + ./update_docu_links.py
Uses guest credentials that were provided in the code.